Review main Merged

57862[TASK] Split site configuration loading into separate method

Benni Mack CR +2 V +2 Easy +20 −8 updated 08/10/18, 19:05

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Georg Ringer +1
    • Oliver Hader +1
  • Verified V +2
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 08/10/18, 18:29

  2. Oliver Hader voted on patch set 1 CR +1 08/10/18, 18:33

  3. TYPO3com voted on patch set 1 V +1 08/10/18, 18:36 Completed build in 07m 19s on Fri, 10 Aug, 08:36 PM Test Summary: 33679 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26374

  4. Georg Ringer voted on patch set 1 V +1 CR +1 08/10/18, 18:45

  5. Frank Nägler voted on patch set 1 V +2 CR +2 08/10/18, 19:05

  6. Frank Nägler merged patch set 2 08/10/18, 19:05