Review main Merged

57870[TASK] Clean up Admin Panel Code

Benni Mack CR +2 V +2 Normal +65 −126 updated 08/11/18, 18:05

Commit message

Due to the Admin Panel refactoring, some helper methods
were deprecated, but need a better description.

Also, the $BE_USER->uc property is set to "AdminPanel"
instead of cryptic string "TSFE_adminConfig" since
AdminPanel is not related to TSFE anymore.

Additionally, some helper methods and properties which
are not in use are removed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 915

  1. Benni Mack uploaded patch set 1 08/11/18, 09:44

  2. TYPO3com voted on patch set 1 V +1 08/11/18, 09:53 Completed build in 09m 10s on Sat, 11 Aug, 11:53 AM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26410

  3. Benni Mack uploaded patch set 2 08/11/18, 10:38

  4. TYPO3com voted on patch set 2 V +1 08/11/18, 10:45 Completed build in 06m 51s on Sat, 11 Aug, 12:45 PM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26413

  5. Wouter Wolters commented on patch set 2 CR -1 08/11/18, 11:35

    on it
  6. Wouter Wolters uploaded patch set 3 08/11/18, 11:39

  7. Wouter Wolters voted on patch set 3 V +1 CR +1 08/11/18, 11:40

  8. TYPO3com voted on patch set 3 V -1 08/11/18, 11:47 Completed build in 08m 17s on Sat, 11 Aug, 01:47 PM Test Summary: 1 of 34762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26419

  9. TYPO3com commented on patch set 3 08/11/18, 12:00 Completed build in 29m 34s on Sat, 11 Aug, 02:00 PM Test Summary: 1 of 34762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26419

  10. TYPO3com commented on patch set 3 08/11/18, 13:19 Completed build in 2h 09m 38s on Sat, 11 Aug, 03:19 PM Test Summary: 1 of 34762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26419

  11. Benni Mack updated the commit message in patch set 4 08/11/18, 14:42

  12. TYPO3com voted on patch set 4 V +1 08/11/18, 14:52 Completed build in 09m 16s on Sat, 11 Aug, 04:52 PM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26428

  13. Wouter Wolters voted on patch set 4 V +1 CR +1 08/11/18, 14:57

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 08/11/18, 18:05

  15. Christian Kuhn merged patch set 5 08/11/18, 18:05