57870[TASK] Clean up Admin Panel Code
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/adminpanel/Classes/Controller/AjaxController.php+7 −7
- typo3/sysext/adminpanel/Classes/Controller/MainController.php+2 −22
- typo3/sysext/adminpanel/Classes/Middleware/AdminPanelInitiator.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/Info/GeneralInformation.php+3 −3
- typo3/sysext/adminpanel/Classes/Modules/AbstractModule.php+3 −19
- typo3/sysext/adminpanel/Classes/Modules/AbstractSubModule.php+1 −1
- typo3/sysext/adminpanel/Classes/Modules/CacheModule.php+2 −2
- typo3/sysext/adminpanel/Classes/Modules/EditModule.php+1 −1
- typo3/sysext/adminpanel/Classes/Service/ConfigurationService.php+4 −4
- typo3/sysext/adminpanel/Classes/View/AdminPanelView.php+32 −59
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php+2 −0
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php+3 −3
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php+3 −3
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php+1 −1
Review log 915
-
Benni Mack uploaded patch set 1 08/11/18, 09:44
-
TYPO3com voted on patch set 1 V +1 08/11/18, 09:53 Completed build in 09m 10s on Sat, 11 Aug, 11:53 AM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26410
-
Benni Mack uploaded patch set 2 08/11/18, 10:38
-
TYPO3com voted on patch set 2 V +1 08/11/18, 10:45 Completed build in 06m 51s on Sat, 11 Aug, 12:45 PM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26413
-
Wouter Wolters commented on patch set 2 CR -1 08/11/18, 11:35
on it -
Wouter Wolters uploaded patch set 3 08/11/18, 11:39
-
Wouter Wolters voted on patch set 3 V +1 CR +1 08/11/18, 11:40
-
TYPO3com voted on patch set 3 V -1 08/11/18, 11:47 Completed build in 08m 17s on Sat, 11 Aug, 01:47 PM Test Summary: 1 of 34762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26419
-
TYPO3com commented on patch set 3 08/11/18, 12:00 Completed build in 29m 34s on Sat, 11 Aug, 02:00 PM Test Summary: 1 of 34762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26419
-
TYPO3com commented on patch set 3 08/11/18, 13:19 Completed build in 2h 09m 38s on Sat, 11 Aug, 03:19 PM Test Summary: 1 of 34762 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26419
-
Benni Mack updated the commit message in patch set 4 08/11/18, 14:42
-
TYPO3com voted on patch set 4 V +1 08/11/18, 14:52 Completed build in 09m 16s on Sat, 11 Aug, 04:52 PM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26428
-
Wouter Wolters voted on patch set 4 V +1 CR +1 08/11/18, 14:57
-
Christian Kuhn voted on patch set 4 V +2 CR +2 08/11/18, 18:05
-
Christian Kuhn merged patch set 5 08/11/18, 18:05