Review main Merged

57875[BUGFIX] Modify SQL Server IDENTITY_INSERT when creating records

Oliver Hader CR +2 V +2 Easy +8 −8 updated 08/12/18, 17:09

Commit message

In SQL Server (MSSQL), hard setting uid auto-increment primary keys is
only allowed if the table is prepared for such an operation beforehand.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 812

  1. Oliver Hader uploaded patch set 1 08/11/18, 15:53

  2. Oliver Hader uploaded patch set 2 08/11/18, 15:56

  3. TYPO3com voted on patch set 1 V +1 08/11/18, 16:03 Completed build in 09m 56s on Sat, 11 Aug, 06:03 PM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26437

  4. TYPO3com voted on patch set 2 V +1 08/11/18, 16:05 Completed build in 09m 11s on Sat, 11 Aug, 06:05 PM Test Summary: 34603 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26438

  5. Oliver Hader commented on patch set 2 CR -1 08/11/18, 16:20

    I received feedback, that performance-wise that would not be good. Thus -1 / however, I just don't have enough knowledge about SQL Server
  6. Oliver Hader uploaded patch set 3 08/11/18, 19:38

  7. TYPO3com voted on patch set 3 V +1 08/11/18, 19:46 Completed build in 08m 01s on Sat, 11 Aug, 09:46 PM Test Summary: 34656 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26454

  8. Oliver Hader voted on patch set 3 CR -1 08/12/18, 08:27

  9. Oliver Hader uploaded patch set 4 08/12/18, 16:41

  10. TYPO3com voted on patch set 4 V +1 08/12/18, 16:51 Completed build in 10m 02s on Sun, 12 Aug, 06:51 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26473

  11. Oliver Hader commented on patch set 4 V +2 CR +2 08/12/18, 17:09

    YOLO! Worked locally for me with SQL Server now... let Bamboo's night tests check it as well...
  12. Oliver Hader merged patch set 5 08/12/18, 17:09