57876[TASK] Deprecate EidUtility and methods within TSFE
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85878-EidUtilityAndVariousTSFEMethods.rstnew+50 −0
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+32 −4
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+10 −4
- typo3/sysext/frontend/Classes/Utility/EidUtility.php2+38 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ArrayDimensionMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+36 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php2+22 −1
Review log 1725
-
Benni Mack uploaded patch set 1 08/11/18, 18:20
-
TYPO3com voted on patch set 1 V +1 08/11/18, 18:29 Completed build in 09m 07s on Sat, 11 Aug, 08:29 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26446
-
Benni Mack uploaded patch set 2 08/15/18, 07:39
-
TYPO3com voted on patch set 2 V +1 08/15/18, 07:47 Completed build in 07m 17s on Wed, 15 Aug, 09:47 AM Test Summary: 34830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26605
-
Richard Haeser voted on patch set 2 CR +1 08/16/18, 19:10
-
Benni Mack uploaded patch set 3 08/16/18, 19:41
-
TYPO3com voted on patch set 3 V +1 08/16/18, 19:50 Completed build in 08m 14s on Thu, 16 Aug, 09:50 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26675
-
Wouter Wolters uploaded patch set 4 08/16/18, 19:56
-
Wouter Wolters uploaded patch set 5 08/16/18, 19:58
-
Wouter Wolters uploaded patch set 6 08/16/18, 19:59
-
TYPO3com voted on patch set 4 V -1 08/16/18, 20:05 Completed build in 09m 24s on Thu, 16 Aug, 10:05 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26678
-
Wouter Wolters uploaded patch set 7 08/16/18, 20:07
-
TYPO3com voted on patch set 5 V -1 08/16/18, 20:08 Completed build in 10m 10s on Thu, 16 Aug, 10:08 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26679
-
TYPO3com voted on patch set 6 V -1 08/16/18, 20:10 Completed build in 09m 18s on Thu, 16 Aug, 10:10 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26680
-
TYPO3com voted on patch set 7 V +1 08/16/18, 20:15 Completed build in 07m 19s on Thu, 16 Aug, 10:15 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26681
-
Wouter Wolters voted on patch set 7 V +1 CR +1 08/16/18, 20:16
-
Christian Kuhn commented on patch set 7 CR -1 08/16/18, 20:32
withMethodCallStaticMatcher.php:739wrong class names here and below. -
Wouter Wolters commented on patch set 7 08/16/18, 20:34
MethodCallStaticMatcher.php:410please change it here too -
Christian Kuhn uploaded patch set 8 08/16/18, 20:39
-
TYPO3com voted on patch set 8 V +1 08/16/18, 20:48 Completed build in 08m 49s on Thu, 16 Aug, 10:48 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26686
-
Christian Kuhn voted on patch set 8 V +1 CR +1 08/16/18, 20:50
-
Wouter Wolters voted on patch set 8 V +2 CR +2 08/16/18, 20:53
-
Wouter Wolters merged patch set 9 08/16/18, 20:53
-
Markus Klein commented on patch set 9 08/16/18, 20:59
EidUtility.php:46wrong messageEidUtility.php:102why this change, if we have "This method .." again below in line 121? -
Wouter Wolters commented on patch set 9 08/17/18, 11:40