Review main Merged

57876[TASK] Deprecate EidUtility and methods within TSFE

Benni Mack CR +2 V +2 Normal +193 −12 updated 08/17/18, 11:40

Commit message

EidUtility is a poor-mans middleware functionality with
lots of side-effects, and is marked as deprecated.

On top, the following methods in
TypoScriptFrontendController are deprecated:
- initFEuser()
- storeSessionData()
- previewInfo()
- hook_eofe()
- addTempContentHttpHeaders()
- sendCacheHeaders()

Additionally, the PreviewInfo Hook
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_previewInfo']
is deprecated, as the eofe hook solves the same issues.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1725

  1. Benni Mack uploaded patch set 1 08/11/18, 18:20

  2. TYPO3com voted on patch set 1 V +1 08/11/18, 18:29 Completed build in 09m 07s on Sat, 11 Aug, 08:29 PM Test Summary: 34599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26446

  3. Benni Mack uploaded patch set 2 08/15/18, 07:39

  4. TYPO3com voted on patch set 2 V +1 08/15/18, 07:47 Completed build in 07m 17s on Wed, 15 Aug, 09:47 AM Test Summary: 34830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26605

  5. Richard Haeser voted on patch set 2 CR +1 08/16/18, 19:10

  6. Benni Mack uploaded patch set 3 08/16/18, 19:41

  7. TYPO3com voted on patch set 3 V +1 08/16/18, 19:50 Completed build in 08m 14s on Thu, 16 Aug, 09:50 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26675

  8. Wouter Wolters uploaded patch set 4 08/16/18, 19:56

  9. Wouter Wolters uploaded patch set 5 08/16/18, 19:58

  10. Wouter Wolters uploaded patch set 6 08/16/18, 19:59

  11. TYPO3com voted on patch set 4 V -1 08/16/18, 20:05 Completed build in 09m 24s on Thu, 16 Aug, 10:05 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26678

  12. Wouter Wolters uploaded patch set 7 08/16/18, 20:07

  13. TYPO3com voted on patch set 5 V -1 08/16/18, 20:08 Completed build in 10m 10s on Thu, 16 Aug, 10:08 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26679

  14. TYPO3com voted on patch set 6 V -1 08/16/18, 20:10 Completed build in 09m 18s on Thu, 16 Aug, 10:10 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26680

  15. TYPO3com voted on patch set 7 V +1 08/16/18, 20:15 Completed build in 07m 19s on Thu, 16 Aug, 10:15 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26681

  16. Wouter Wolters voted on patch set 7 V +1 CR +1 08/16/18, 20:16

  17. Christian Kuhn commented on patch set 7 CR -1 08/16/18, 20:32

    with

    MethodCallStaticMatcher.php:739

    wrong class names here and below.
  18. Wouter Wolters commented on patch set 7 08/16/18, 20:34

    MethodCallStaticMatcher.php:410

    please change it here too
  19. Christian Kuhn uploaded patch set 8 08/16/18, 20:39

  20. TYPO3com voted on patch set 8 V +1 08/16/18, 20:48 Completed build in 08m 49s on Thu, 16 Aug, 10:48 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26686

  21. Christian Kuhn voted on patch set 8 V +1 CR +1 08/16/18, 20:50

  22. Wouter Wolters voted on patch set 8 V +2 CR +2 08/16/18, 20:53

  23. Wouter Wolters merged patch set 9 08/16/18, 20:53

  24. Markus Klein commented on patch set 9 08/16/18, 20:59

    EidUtility.php:46

    wrong message

    EidUtility.php:102

    why this change, if we have "This method .." again below in line 121?
  25. Wouter Wolters commented on patch set 9 08/17/18, 11:40