Review main Merged

57880[TASK] Deprecate PageGenerator::renderContent

Benni Mack CR +2 V +2 Normal +80 −1 updated 08/12/18, 17:11

Commit message

The PSR-15 RequestHandler should be responsible for compiling content, avoiding
a call to a static method which uses global objects again, which are available
already in the RequestHandler.

Therefore this logic is moved into RequestHandler.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack uploaded patch set 1 08/12/18, 11:19

  2. TYPO3com voted on patch set 1 V +1 08/12/18, 11:28 Completed build in 09m 09s on Sun, 12 Aug, 01:28 PM Test Summary: 34680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26470

  3. Wouter Wolters uploaded patch set 2 08/12/18, 12:10

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 08/12/18, 12:16

  5. TYPO3com voted on patch set 2 V +1 08/12/18, 12:20 Completed build in 09m 18s on Sun, 12 Aug, 02:20 PM Test Summary: 34680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26471

  6. Georg Ringer voted on patch set 2 V +2 CR +2 08/12/18, 17:11

  7. Georg Ringer merged patch set 3 08/12/18, 17:11