Review main Merged

57885[TASK] Merge EXT:saltedpasswords into EXT:core

Christian Kuhn CR +2 V +2 Expert +647 −1408 updated 08/14/18, 08:42

Commit message

Move all classes and other resources from EXT:saltedpasswords to
EXT:core.

Classes live in TYPO3\CMS\Core\Crypto\PasswordHashing. This namespace
will be clean in v10 when the classes that are currently only kept for
backwards compatibility are removed.

The documentation has been integrated into the "Core API" docs at
https://docs.typo3.org/typo3cms/CoreApiReference/stable/ApiOverview/PasswordHashing/

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stephan Großberndt +1
    • Benni Mack +1
  • Verified V +2
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 86

Show 66 more files

Review log 3345

Show 1320 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/13/18, 12:01

  2. Christian Kuhn voted on patch set 1 CR -2 08/13/18, 12:01

  3. TYPO3com voted on patch set 1 V -1 08/13/18, 12:04 Completed build in 29s on Mon, 13 Aug, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26490

  4. Christian Kuhn uploaded patch set 2 08/13/18, 12:06

  5. TYPO3com voted on patch set 2 V +1 08/13/18, 12:16 Completed build in 09m 16s on Mon, 13 Aug, 02:16 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26491

  6. Christian Kuhn uploaded patch set 3 08/13/18, 12:28

  7. Christian Kuhn uploaded patch set 4 08/13/18, 12:34

  8. TYPO3com voted on patch set 3 V +1 08/13/18, 12:38 Completed build in 10m 19s on Mon, 13 Aug, 02:38 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26492

  9. Christian Kuhn voted on patch set 4 CR 0 08/13/18, 12:44

  10. Christian Kuhn updated the commit message in patch set 5 08/13/18, 12:50

  11. TYPO3com voted on patch set 4 V +1 08/13/18, 13:03 Completed build in 27m 08s on Mon, 13 Aug, 03:03 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26495

  12. TYPO3com voted on patch set 5 V +1 08/13/18, 13:07 Completed build in 12m 43s on Mon, 13 Aug, 03:07 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26496

  13. Christian Kuhn commented on patch set 5 CR -2 08/13/18, 13:09

    oops. found an issue ...
  14. Christian Kuhn uploaded patch set 6 08/13/18, 13:15

  15. Christian Kuhn voted on patch set 6 CR 0 08/13/18, 13:15

  16. TYPO3com voted on patch set 6 V +1 08/13/18, 13:23 Completed build in 07m 42s on Mon, 13 Aug, 03:23 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26498

  17. Christian Kuhn updated the commit message in patch set 7 08/13/18, 13:27

  18. TYPO3com voted on patch set 7 V +1 08/13/18, 13:37 Completed build in 09m 52s on Mon, 13 Aug, 03:37 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26499

  19. Stephan Großberndt updated the commit message in patch set 8 08/13/18, 13:46

  20. Stephan Großberndt commented on patch set 8 08/13/18, 13:48

    Deprecation-85833-ExtensionSaltedpasswordsMergedIntoCoreExtension.rst:19

    rather in v10 ?!
  1. TYPO3com voted on patch set 8 V +1 08/13/18, 13:54 Completed build in 08m 40s on Mon, 13 Aug, 03:54 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26500

  2. Christian Kuhn uploaded patch set 9 08/13/18, 14:56

  3. TYPO3com voted on patch set 9 V +1 08/13/18, 15:05 Completed build in 08m 39s on Mon, 13 Aug, 05:05 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26501

  4. Wouter Wolters voted on patch set 9 CR +1 08/13/18, 17:29

  5. Richard Haeser voted on patch set 9 CR +1 08/13/18, 18:39

  6. Benni Mack commented on patch set 9 CR -1 08/13/18, 20:14

    on it.
  7. Benni Mack uploaded patch set 10 08/13/18, 20:25

  8. Benni Mack commented on patch set 10 V +1 CR +1 08/13/18, 20:27

    Found a small issue in XLF handling, and added an RST
  9. Richard Haeser voted on patch set 10 CR +1 08/13/18, 20:28

  10. TYPO3com voted on patch set 10 V -1 08/13/18, 20:33 Completed build in 07m 17s on Mon, 13 Aug, 10:33 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26515

  11. Stephan Großberndt commented on patch set 10 08/13/18, 20:41

    Important-85833-SaltedpasswordsExtensionMergedIntoCoreExtension.rst:34

    Bamboo complains: insert '.. index:: <at least one valid keyword>' at last line of the file. See Build/Scripts/validateRstFiles.php for allowed keywords
  12. Stephan Großberndt commented on patch set 11 08/13/18, 20:44

    Published edit on patch set 10.
  13. Stephan Großberndt commented on patch set 11 08/13/18, 20:53

    Once this is merged this suggestion should be removed: https://github.com/TYPO3/testing-framework/blob/master/composer.json#L41
  14. TYPO3com voted on patch set 11 V +1 08/13/18, 20:54 Completed build in 10m 05s on Mon, 13 Aug, 10:54 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26516

  15. Stephan Großberndt commented on patch set 12 08/13/18, 21:01

    Published edit on patch set 11.
  16. Stephan Großberndt voted on patch set 12 CR +1 08/13/18, 21:09

  17. TYPO3com voted on patch set 12 V +1 08/13/18, 21:10 Completed build in 08m 31s on Mon, 13 Aug, 11:10 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26519

  18. Benni Mack voted on patch set 12 V +1 CR +1 08/14/18, 04:09

  19. Georg Ringer voted on patch set 12 V +2 CR +2 08/14/18, 04:18

  20. Georg Ringer merged patch set 13 08/14/18, 04:18

  21. Markus Klein commented on patch set 13 08/14/18, 04:25

    I was too slow with my review.. Post -1 typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml:363 needs adjustments too
  22. Markus Klein commented on patch set 13 08/14/18, 04:33

    ExtensionManagerConfigurationUtility.php:49

    Are we sure about this reference here?
  23. Christian Kuhn commented on patch set 13 08/14/18, 08:11

    ExtensionManagerConfigurationUtility.php:49 Reply

    i didn't change these since all of the consuming php classes are deprecated, too.
  24. Markus Klein commented on patch set 13 08/14/18, 08:36

    ExtensionManagerConfigurationUtility.php:49 Reply

    okay.
  25. Markus Klein commented on patch set 13 08/14/18, 08:42