57885[TASK] Merge EXT:saltedpasswords into EXT:core
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Stephan Großberndt +1
- Benni Mack +1
-
Verified V +2
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 2
Files 86
- typo3/sysext/core/Classes/Authentication/AuthenticationService.php+9 −9
- typo3/sysext/core/Classes/Authentication/CommandLineUserAuthentication.php+2 −2
- typo3/sysext/core/Classes/Crypto/PasswordHashing/AbstractComposedSalt.phprenamed+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Argon2iPasswordHash.phprenamed+4 −5
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BcryptPasswordHash.phprenamed+4 −5
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BlowfishPasswordHash.phprenamed+5 −4
- typo3/sysext/core/Classes/Crypto/PasswordHashing/ComposedPasswordHashInterface.phprenamed+2 −2
- typo3/sysext/core/Classes/Crypto/PasswordHashing/ExtensionManagerConfigurationUtility.php3renamed+3 −3
- typo3/sysext/core/Classes/Crypto/PasswordHashing/InvalidPasswordHashException.phprenamed+3 −3
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Md5PasswordHash.phprenamed+4 −4
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PasswordHashFactory.phprenamed+22 −24
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PasswordHashInterface.phprenamed+2 −2
- typo3/sysext/core/Classes/Crypto/PasswordHashing/Pbkdf2PasswordHash.phprenamed+5 −5
- typo3/sysext/core/Classes/Crypto/PasswordHashing/PhpassPasswordHash.phprenamed+4 −4
- typo3/sysext/core/Classes/Crypto/PasswordHashing/SaltedPasswordService.phprenamed+8 −9
- typo3/sysext/core/Classes/Crypto/PasswordHashing/SaltedPasswordsUtility.phprenamed+6 −4
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+5 −5
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+11 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+8 −8
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85833-ExtensionSaltedpasswordsMergedIntoCoreExtension.rst1new+62 −0
Show 66 more files
- typo3/sysext/core/Documentation/Changelog/master/Important-85833-SaltedpasswordsExtensionMergedIntoCoreExtension.rst1new+34 −0
- typo3/sysext/core/Migrations/Code/ClassAliasMap.php+15 −0
- typo3/sysext/core/Migrations/Code/LegacyClassesForIde.php+57 −0
- typo3/sysext/core/Resources/Private/Language/locallang_deprecated_saltedpasswords.xlfrenamed+0 −0
- typo3/sysext/core/Resources/Private/Language/locallang_deprecated_saltedpasswords_em.xlfrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/Fixtures/be_users.xmlrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/Fixtures/fe_users.xmlrenamed+0 −0
- typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/SaltedPasswordServiceTest.phprenamed+4 −4
- typo3/sysext/core/Tests/Functional/Crypto/PasswordHashing/SaltedPasswordsUtilityTest.phprenamed+4 −4
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Fixtures/TestPasswordHash.phprenamed+4 −4
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.phprenamed+12 −12
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.phprenamed+9 −9
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BlowfishPasswordHashTest.phprenamed+19 −19
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Md5PasswordHashTest.phprenamed+15 −15
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/PasswordHashFactoryTest.phprenamed+50 −50
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Pbkdf2PaswordHashTest.phprenamed+20 −20
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/PhpassPasswordHashTest.phprenamed+19 −19
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/Argon2iPasswordHashTest.phprenamed+7 −7
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/BcryptPasswordHashTest.phprenamed+5 −5
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/BlowfishPasswordHashTest.phprenamed+4 −4
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/Md5PasswordHashTest.phprenamed+5 −5
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/PasswordHashFactoryTest.phprenamed+16 −16
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/Pbkdf2PasswordHashTest.phprenamed+5 −5
- typo3/sysext/core/Tests/UnitDeprecated/Crypto/PasswordHashing/PhpassPasswordHashTest.phprenamed+5 −5
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php+2 −2
- typo3/sysext/install/Classes/Authentication/AuthenticationService.php+4 −4
- typo3/sysext/install/Classes/Configuration/PasswordHashing/Argon2iPreset.php+5 −5
- typo3/sysext/install/Classes/Configuration/PasswordHashing/BcryptPreset.php+5 −5
- typo3/sysext/install/Classes/Configuration/PasswordHashing/CustomPreset.php+1 −1
- typo3/sysext/install/Classes/Configuration/PasswordHashing/Pbkdf2Preset.php+5 −5
- typo3/sysext/install/Classes/Configuration/PasswordHashing/PhpassPreset.php+5 −5
- typo3/sysext/install/Classes/Controller/InstallerController.php+13 −13
- typo3/sysext/install/Classes/Controller/MaintenanceController.php+2 −2
- typo3/sysext/install/Classes/Controller/SettingsController.php+2 −2
- typo3/sysext/install/Classes/Http/RequestHandler.php+2 −2
- typo3/sysext/install/Classes/Report/SecurityStatusReport.php+4 −4
- typo3/sysext/install/Classes/Service/SilentConfigurationUpgradeService.php+12 −12
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+76 −6
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+20 −20
- typo3/sysext/reports/Classes/Report/Status/SecurityStatus.php+4 −4
- typo3/sysext/reports/Resources/Private/Language/locallang_reports.xlf+0 −9
- typo3/sysext/saltedpasswords/Documentation/Configuration/Index.rstdeleted+0 −38
- typo3/sysext/saltedpasswords/Documentation/Credits/Index.rstdeleted+0 −33
- typo3/sysext/saltedpasswords/Documentation/DevelopersGuide/Index.rstdeleted+0 −86
- typo3/sysext/saltedpasswords/Documentation/Images/ExtensionConfigurationCheck.pngdeletedbinary
- typo3/sysext/saltedpasswords/Documentation/Images/SaltedHashInDatabase.pngdeletedbinary
- typo3/sysext/saltedpasswords/Documentation/Installation/Index.rstdeleted+0 −97
- typo3/sysext/saltedpasswords/Documentation/Introduction/Index.rstdeleted+0 −41
- typo3/sysext/saltedpasswords/Documentation/Licenses/Index.rstdeleted+0 −38
- typo3/sysext/saltedpasswords/Documentation/Overview/Index.rstdeleted+0 −99
- typo3/sysext/saltedpasswords/Documentation/.gitignoredeleted+0 −7
- typo3/sysext/saltedpasswords/Documentation/Includes.txtdeleted+0 −21
- typo3/sysext/saltedpasswords/Documentation/Index.rstdeleted+0 −66
- typo3/sysext/saltedpasswords/Documentation/Settings.cfgdeleted+0 −25
- typo3/sysext/saltedpasswords/Documentation/Targets.rstdeleted+0 −13
- typo3/sysext/saltedpasswords/Migrations/Code/ClassAliasMap.phpdeleted+0 −4
- typo3/sysext/saltedpasswords/Resources/Public/Icons/Extension.pngdeletedbinary
- typo3/sysext/saltedpasswords/.gitattributesdeleted+0 −3
- typo3/sysext/saltedpasswords/composer.jsondeleted+0 −52
- typo3/sysext/saltedpasswords/ext_emconf.phpdeleted+0 −23
- typo3/sysext/saltedpasswords/ext_localconf.phpdeleted+0 −5
- typo3/sysext/saltedpasswords/LICENSE.txtdeleted+0 −345
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+4 −4
- composer.json+0 −4
- composer.lock+1 −1
Review log 3345
Show 1320 earlier messages
-
Christian Kuhn uploaded patch set 1 08/13/18, 12:01
-
Christian Kuhn voted on patch set 1 CR -2 08/13/18, 12:01
-
TYPO3com voted on patch set 1 V -1 08/13/18, 12:04 Completed build in 29s on Mon, 13 Aug, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26490
-
Christian Kuhn uploaded patch set 2 08/13/18, 12:06
-
TYPO3com voted on patch set 2 V +1 08/13/18, 12:16 Completed build in 09m 16s on Mon, 13 Aug, 02:16 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26491
-
Christian Kuhn uploaded patch set 3 08/13/18, 12:28
-
Christian Kuhn uploaded patch set 4 08/13/18, 12:34
-
TYPO3com voted on patch set 3 V +1 08/13/18, 12:38 Completed build in 10m 19s on Mon, 13 Aug, 02:38 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26492
-
Christian Kuhn voted on patch set 4 CR 0 08/13/18, 12:44
-
Christian Kuhn updated the commit message in patch set 5 08/13/18, 12:50
-
TYPO3com voted on patch set 4 V +1 08/13/18, 13:03 Completed build in 27m 08s on Mon, 13 Aug, 03:03 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26495
-
TYPO3com voted on patch set 5 V +1 08/13/18, 13:07 Completed build in 12m 43s on Mon, 13 Aug, 03:07 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26496
-
Christian Kuhn commented on patch set 5 CR -2 08/13/18, 13:09
oops. found an issue ... -
Christian Kuhn uploaded patch set 6 08/13/18, 13:15
-
Christian Kuhn voted on patch set 6 CR 0 08/13/18, 13:15
-
TYPO3com voted on patch set 6 V +1 08/13/18, 13:23 Completed build in 07m 42s on Mon, 13 Aug, 03:23 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26498
-
Christian Kuhn updated the commit message in patch set 7 08/13/18, 13:27
-
TYPO3com voted on patch set 7 V +1 08/13/18, 13:37 Completed build in 09m 52s on Mon, 13 Aug, 03:37 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26499
-
Stephan Großberndt updated the commit message in patch set 8 08/13/18, 13:46
-
Stephan Großberndt commented on patch set 8 08/13/18, 13:48
Deprecation-85833-ExtensionSaltedpasswordsMergedIntoCoreExtension.rst:19rather in v10 ?!
-
TYPO3com voted on patch set 8 V +1 08/13/18, 13:54 Completed build in 08m 40s on Mon, 13 Aug, 03:54 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26500
-
Christian Kuhn uploaded patch set 9 08/13/18, 14:56
-
TYPO3com voted on patch set 9 V +1 08/13/18, 15:05 Completed build in 08m 39s on Mon, 13 Aug, 05:05 PM Test Summary: 34725 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26501
-
Wouter Wolters voted on patch set 9 CR +1 08/13/18, 17:29
-
Richard Haeser voted on patch set 9 CR +1 08/13/18, 18:39
-
Benni Mack commented on patch set 9 CR -1 08/13/18, 20:14
on it. -
Benni Mack uploaded patch set 10 08/13/18, 20:25
-
Benni Mack commented on patch set 10 V +1 CR +1 08/13/18, 20:27
Found a small issue in XLF handling, and added an RST -
Richard Haeser voted on patch set 10 CR +1 08/13/18, 20:28
-
TYPO3com voted on patch set 10 V -1 08/13/18, 20:33 Completed build in 07m 17s on Mon, 13 Aug, 10:33 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26515
-
Stephan Großberndt commented on patch set 10 08/13/18, 20:41
Important-85833-SaltedpasswordsExtensionMergedIntoCoreExtension.rst:34Bamboo complains: insert '.. index:: <at least one valid keyword>' at last line of the file. See Build/Scripts/validateRstFiles.php for allowed keywords -
Stephan Großberndt commented on patch set 11 08/13/18, 20:44
Published edit on patch set 10. -
Stephan Großberndt commented on patch set 11 08/13/18, 20:53
Once this is merged this suggestion should be removed: https://github.com/TYPO3/testing-framework/blob/master/composer.json#L41 -
TYPO3com voted on patch set 11 V +1 08/13/18, 20:54 Completed build in 10m 05s on Mon, 13 Aug, 10:54 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26516
-
Stephan Großberndt commented on patch set 12 08/13/18, 21:01
Published edit on patch set 11. -
Stephan Großberndt voted on patch set 12 CR +1 08/13/18, 21:09
-
TYPO3com voted on patch set 12 V +1 08/13/18, 21:10 Completed build in 08m 31s on Mon, 13 Aug, 11:10 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26519
-
Benni Mack voted on patch set 12 V +1 CR +1 08/14/18, 04:09
-
Georg Ringer voted on patch set 12 V +2 CR +2 08/14/18, 04:18
-
Georg Ringer merged patch set 13 08/14/18, 04:18
-
Markus Klein commented on patch set 13 08/14/18, 04:25
I was too slow with my review.. Post -1 typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml:363 needs adjustments too -
Markus Klein commented on patch set 13 08/14/18, 04:33
ExtensionManagerConfigurationUtility.php:49Are we sure about this reference here? -
Christian Kuhn commented on patch set 13 08/14/18, 08:11
ExtensionManagerConfigurationUtility.php:49Replyi didn't change these since all of the consuming php classes are deprecated, too. -
Markus Klein commented on patch set 13 08/14/18, 08:36
ExtensionManagerConfigurationUtility.php:49Replyokay. -
Markus Klein commented on patch set 13 08/14/18, 08:42