Review main Merged

57888[TASK] Add unit tests for CommandUtility::unQuoteFilenames

Wouter Wolters CR +2 V +2 Normal +121 −2 updated 08/14/18, 10:28

Commit message

While moving this method to CommandUtility class the unit tests
were missing. They are re-added now.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Wouter Wolters uploaded patch set 1 08/13/18, 18:47

  2. TYPO3com voted on patch set 1 V +1 08/13/18, 18:56 Completed build in 09m 06s on Mon, 13 Aug, 08:56 PM Test Summary: 34755 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26509

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/14/18, 09:21

  4. Christian Kuhn commented on patch set 1 CR -1 08/14/18, 10:09

    i'll apply some cosmetics.
  5. Christian Kuhn uploaded patch set 2 08/14/18, 10:12

  6. TYPO3com voted on patch set 2 V +1 08/14/18, 10:20 Completed build in 07m 35s on Tue, 14 Aug, 12:20 PM Test Summary: 34809 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26532

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/14/18, 10:25

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 08/14/18, 10:28

  9. Andreas Kienast merged patch set 3 08/14/18, 10:28