Review main Merged

57890[BUGFIX] Show correct rendering times in admin panel

Tymoteusz Motylewski CR +2 V +2 Easy +10 −8 updated 08/22/18, 09:00

Commit message

* adds missing timetracker->push()
* removes unnecessary call to printTSlog
* reuse existing variable in fixContent, to avoid notices

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 811

  1. Tymoteusz Motylewski uploaded patch set 1 08/13/18, 20:50

  2. TYPO3com voted on patch set 1 V +1 08/13/18, 20:59 Completed build in 09m 01s on Mon, 13 Aug, 10:59 PM Test Summary: 34779 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26518

  3. Susi Moog uploaded patch set 2 08/20/18, 16:13

  4. TYPO3com voted on patch set 2 V +1 08/20/18, 16:22 Completed build in 08m 21s on Mon, 20 Aug, 06:22 PM Test Summary: 34905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26834

  5. Tymoteusz Motylewski uploaded patch set 3 08/21/18, 10:14

  6. TYPO3com voted on patch set 3 V +1 08/21/18, 10:23 Completed build in 08m 56s on Tue, 21 Aug, 12:23 PM Test Summary: 34905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26846

  7. Susi Moog voted on patch set 3 CR +1 08/21/18, 11:01

  8. Georg Ringer voted on patch set 3 V +1 CR +1 08/22/18, 06:36

  9. Susi Moog voted on patch set 3 V +1 08/22/18, 08:13

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 08/22/18, 09:00

  11. Christian Kuhn merged patch set 4 08/22/18, 09:00