Review main Merged

57911[TASK] Remove toggle function from page tree root element

Paweł Rogowicz CR +2 V +2 Easy +13 −3 updated 08/27/18, 15:37

Commit message

Remove toggle function from root node and set expanded on true if there
is only one node on depth 0. If there is more then 1
(e.g. when using DB Mounts) then keep toggle option.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Riccardo De Contardi +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Paweł Rogowicz uploaded patch set 1 08/15/18, 10:13

  2. TYPO3com voted on patch set 1 V +1 08/15/18, 10:22 Completed build in 09m 05s on Wed, 15 Aug, 12:22 PM Test Summary: 34830 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26611

  3. Tymoteusz Motylewski commented on patch set 1 CR -1 08/15/18, 14:16

    Lets call it a task or bugfix, as this brings back the same functionality there was in v8.
  4. Tymoteusz Motylewski updated the commit message in patch set 2 08/15/18, 20:01

  5. TYPO3com voted on patch set 2 V +1 08/15/18, 20:09 Completed build in 08m 04s on Wed, 15 Aug, 10:09 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26637

  6. Riccardo De Contardi commented on patch set 2 V +1 08/16/18, 09:04

    The vertical dotted line should be aligned to match the situation on version 8, I think (same if you use an editor). For the rest, the patch works. I can provide a screenshot if needed. Thanks.
  7. Tymoteusz Motylewski commented on patch set 2 08/26/18, 09:24

    The line can be chanegd in the separate change. Lets not add more to this one.
  8. Christian Kuhn voted on patch set 2 V +1 CR +1 08/27/18, 12:31

  9. Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/27/18, 15:37

  10. Tymoteusz Motylewski merged patch set 3 08/27/18, 15:37