Review main Merged

57923[TEST] Extend site handling link generation tests

Oliver Hader CR +2 V +2 Expert +1340 −70 updated 08/22/18, 12:59

Commit message

Current side handling functional test cases only support link
resolving and rendering. The opposite part of generating links
has been introduced with this change.

Besides that, existing rendering tests have been extended for
frontend restricted page rendering.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 1423

  1. Oliver Hader uploaded patch set 1 08/15/18, 19:21

  2. TYPO3com voted on patch set 1 V -1 08/15/18, 19:21 Completed build in 09s on Wed, 15 Aug, 09:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26632

  3. Oliver Hader uploaded patch set 2 08/15/18, 19:23

  4. TYPO3com voted on patch set 2 V -1 08/15/18, 19:31 Completed build in 07m 31s on Wed, 15 Aug, 09:31 PM Test Summary: 6 of 35001 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26633

  5. Oliver Hader uploaded patch set 3 08/15/18, 19:31

  6. TYPO3com voted on patch set 3 V -1 08/15/18, 19:31 Completed build in 09s on Wed, 15 Aug, 09:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26634

  7. Oliver Hader uploaded patch set 4 08/18/18, 21:15

  8. Oliver Hader commented on patch set 4 08/18/18, 21:15

    Requires testing framework upgrade
  9. TYPO3com voted on patch set 4 V -1 08/18/18, 21:24 Completed build in 08m 38s on Sat, 18 Aug, 11:24 PM Test Summary: 234 of 35302 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26778

  10. Oliver Hader uploaded patch set 5 08/20/18, 14:42

  11. TYPO3com voted on patch set 5 V -1 08/20/18, 14:42 Completed build in 10s on Mon, 20 Aug, 04:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26829

  12. Oliver Hader uploaded patch set 6 08/20/18, 14:48

  13. TYPO3com voted on patch set 6 V -1 08/20/18, 14:53 Completed build in 05m 01s on Mon, 20 Aug, 04:53 PM Test Summary: 29403 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26830

  14. Oliver Hader uploaded patch set 7 08/20/18, 14:55

  15. TYPO3com voted on patch set 7 V -1 08/20/18, 15:05 Completed build in 09m 55s on Mon, 20 Aug, 05:05 PM Test Summary: 18 of 35706 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26831

  16. Oliver Hader commented on patch set 7 08/20/18, 15:12

    The failed tests are topic to be discussed (or to be fixed). Basically related to extend to subpages behavior when generating(!) links to nested pages of some parent that has some access restriction
  17. Oliver Hader uploaded patch set 8 08/21/18, 13:02

  18. TYPO3com voted on patch set 8 V +1 08/21/18, 13:13 Completed build in 10m 40s on Tue, 21 Aug, 03:13 PM Test Summary: 35517 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26853

  19. Oliver Hader uploaded patch set 9 08/22/18, 10:28

  20. TYPO3com voted on patch set 9 V +1 08/22/18, 10:43 Completed build in 13m 06s on Wed, 22 Aug, 12:43 PM Test Summary: 35553 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26877

  21. Benni Mack voted on patch set 9 V +1 CR +1 08/22/18, 10:46

  22. Benni Mack voted on patch set 9 V +2 CR +2 08/22/18, 12:59

  23. Benni Mack merged patch set 10 08/22/18, 12:59