Review main Merged

57925[TASK] Clean up FrontendEditing Controller

Benni Mack CR +2 V +2 Normal +84 −57 updated 08/16/18, 14:21

Commit message

The FrontendEditingController class in EXT:core does two things:
- persisting incoming GET/POST requests (actually only when EXT:feedit is installed)
- rendering editIcons and editIconPanel

In order to separate these concerns, the first patch extracts some minor functionality into
EXT:feedit, and cleans up code which should have been done long ago.

The next iteration will be to deprecate unused methods and properties, and to move
FrontendEditingController into EXT:feedit, however, using an Interface to
render editIcons and editPanels instead.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Frank Nägler +1
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 08/15/18, 20:19

  2. TYPO3com voted on patch set 1 V +1 08/15/18, 20:28 Completed build in 09m 13s on Wed, 15 Aug, 10:28 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26638

  3. Frank Nägler voted on patch set 1 V +1 CR +1 08/16/18, 09:50

  4. Wouter Wolters voted on patch set 1 CR +1 08/16/18, 11:07

  5. Jörg Bösche voted on patch set 1 CR +1 08/16/18, 12:45

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 08/16/18, 14:21

  7. Andreas Kienast merged patch set 2 08/16/18, 14:21