Review main Merged

57928[BUGFIX] Port for Symfony-Route must be a string

Julian Wundrak CR +2 V +2 Easy +1 −1 updated 08/17/18, 10:33

Commit message

We use parse_url to determine the port, but symfony-route requires a string.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Georg Ringer +1
    • Jan Helke +1
    • Jörg Bösche +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Julian Wundrak uploaded patch set 1 08/16/18, 11:41

  2. TYPO3com voted on patch set 1 V +1 08/16/18, 11:49 Completed build in 08m 13s on Thu, 16 Aug, 01:49 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26659

  3. Georg Ringer voted on patch set 1 CR +1 08/16/18, 12:18

  4. Jörg Bösche voted on patch set 1 CR +1 08/16/18, 12:43

  5. Jan Helke voted on patch set 1 V +1 CR +1 08/17/18, 09:39

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 08/17/18, 10:32

  7. Christian Kuhn merged patch set 2 08/17/18, 10:33