57929[BUGFIX] Typolink misses port in absolute url.
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2532
Show 67 earlier messages
-
Julian Wundrak uploaded patch set 1 08/16/18, 12:32
-
TYPO3com voted on patch set 1 V +1 08/16/18, 12:39 Completed build in 06m 57s on Thu, 16 Aug, 02:39 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26660
-
Jörg Bösche voted on patch set 1 CR +1 08/16/18, 14:37
-
Jan Helke commented on patch set 1 CR -1 08/17/18, 09:34
Hey Julian Thanks for your contribution. Would you please mind to look at https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/latest/singlehtml/Index.html#commit-message-rules-for-typo3-cms and adjust the line length of your commit message accordingly? As we will process the commit messages later on, it is mandatory to stick to the max line widths. -
Julian Wundrak updated the commit message in patch set 2 08/17/18, 09:44
-
Jan Helke voted on patch set 2 CR +1 08/17/18, 09:45
-
Julian Wundrak commented on patch set 2 08/17/18, 09:45
@Jan Helke. Sorry. Done this and add Warnings to my IDE for the next time :)
-
Jörg Bösche voted on patch set 2 CR +1 08/17/18, 09:46
-
Jan Helke commented on patch set 2 08/17/18, 09:50
We have also a git hook for this issue :-) https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Setup/Git/Index.html#commit-msg-hook -
TYPO3com voted on patch set 2 V +1 08/17/18, 09:53 Completed build in 08m 53s on Fri, 17 Aug, 11:53 AM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26720
-
Guido Schmechel voted on patch set 2 CR +1 08/19/18, 14:25
-
Julian Wundrak rebased onto patch set 3 08/20/18, 12:32
-
TYPO3com voted on patch set 3 V +1 08/20/18, 12:42 Completed build in 09m 30s on Mon, 20 Aug, 02:42 PM Test Summary: 34905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26826
-
Benni Mack commented on patch set 3 08/21/18, 05:12
Hey Julian, don't get that. if your CURRENT domain runs on a non-standard port and you do cross-domain linking, how do you know the other domains runs on the same port than the CURRENT domain? -
Julian Wundrak commented on patch set 3 08/21/18, 05:44
Hi Benni, That's why im asking in Slack, if i need to add the port to the sys_domain records. I expect (like in TYPO3 7.6), that when TYPO3 runs on e.g. typo.localhost:8080 and I render a HMENU with absolute URIs, the Menu-Items links to typo.localhost:8080 and not only to typo.localhost. -
Benni Mack commented on patch set 3 10/01/18, 18:13
can you rebase this change? -
Julian Wundrak commented on patch set 3 10/01/18, 18:21
sure. do this tomorrow -
Julian Wundrak uploaded patch set 4 10/02/18, 08:15
-
TYPO3com voted on patch set 4 V -1 10/02/18, 08:31 Completed build in 14m 11s on Tue, 2 Oct, 10:31 AM Test Summary: 2 of 38154 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29268
-
TYPO3com commented on patch set 4 10/02/18, 08:45 Completed build in 42m 41s on Tue, 2 Oct, 10:45 AM Test Summary: 2 of 38154 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29268
-
Josef Glatz commented on patch set 4 CR -1 10/02/18, 13:32
sounds incomprehensible. Could you please adopt it? -
Julian Wundrak uploaded patch set 5 10/02/18, 15:21
-
TYPO3com voted on patch set 5 V -1 10/02/18, 15:32 Completed build in 11m 35s on Tue, 2 Oct, 05:32 PM Test Summary: 3 of 38155 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29278
-
Andreas Kienast rebased onto patch set 6 10/03/18, 06:35
-
TYPO3com voted on patch set 6 V +1 10/03/18, 06:56 Completed build in 16m 19s on Wed, 3 Oct, 08:56 AM Test Summary: 37792 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29287
-
Rudy Gnodde voted on patch set 6 CR +1 10/05/18, 14:07
-
Tomas Norre Mikkelsen voted on patch set 6 CR +1 10/05/18, 16:54
-
Benni Mack commented on patch set 6 10/30/18, 21:22
can we add some tests here please? I know at least for master we have tests. -
Frank Nägler commented on patch set 6 CR -1 11/02/18, 11:28
PageLinkBuilder.php:438$GLOBALS['TYPO3_REQUEST']->getAttribute('normalizedParams')->getRequestPort() should be used for master here. The default is 0 if not explicit set, so the 0 should be handled here. -
Benni Mack commented on patch set 6 CR -1 11/08/18, 19:23
Julian, I don't know if this change has rather large sideeffects. The current (non-site-based) handling has this "guessing". So we're adding a guessing as well. Namely that right now we assume that the different domain runs on this port as well, which might break in very complex scenarios (even more) now... -
Julian Wundrak commented on patch set 6 11/14/18, 18:00
Hey Benny, after the whole SiteConfiguration changes, this is no problem for me and we can close this. The problem is still in 8.7, but no one add an issue. So all fine for me -
Benni Mack abandoned the change 11/14/18, 18:35