Review main Merged

57935[BUGFIX] Use non-static method getCache in Avatar class

Wouter Wolters CR +2 V +2 Easy +2 −2 updated 08/16/18, 20:43

Commit message

The getCache method is not static but called as static twice.
Use $this->getCache() instead.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Wouter Wolters uploaded patch set 1 08/16/18, 20:29

  2. TYPO3com voted on patch set 1 V +1 08/16/18, 20:37 Completed build in 08m 27s on Thu, 16 Aug, 10:37 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26684

  3. Markus Klein voted on patch set 1 V +1 CR +1 08/16/18, 20:38

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 08/16/18, 20:43

  5. Christian Kuhn merged patch set 2 08/16/18, 20:43

  6. Christian Kuhn commented on patch set 2 08/16/18, 20:43

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4133d3293e99a4342f12941ab01e436f281ff25a