57938[BUGFIX] Fix non-static call to getLogger in TypoScriptParser
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Christian Kuhn +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 56
-
Wouter Wolters uploaded patch set 1 08/16/18, 21:05
-
TYPO3com voted on patch set 1 V +1 08/16/18, 21:13 Completed build in 07m 53s on Thu, 16 Aug, 11:13 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26692
-
Christian Kuhn voted on patch set 1 V +1 CR +1 08/16/18, 21:20
-
Christian Kuhn commented on patch set 1 08/16/18, 21:28
better solution would be to use the LoggerAwareInterface and the LoggerTrait, and then just remove the protected getLogger() method altogether. However, we could do that patch now and have another one to refactor that thing a bit. -
Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 08/16/18, 22:22
-
Tymoteusz Motylewski merged patch set 2 08/16/18, 22:22