Review main Merged

57939[BUGFIX] Fix calling checkIncludeLines non statically in BackendLayoutView

Wouter Wolters CR +2 V +2 Easy +4 −3 updated 08/20/18, 12:52

Commit message

The method checkIncludeLines in TypoScriptParser should be called
statically in the class BackendLayoutView.

Review

  • Code review CR +2
    • Jan Helke +2
    • Georg Ringer +1
  • Verified V +2
    • Jan Helke +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Wouter Wolters uploaded patch set 1 08/16/18, 21:21

  2. TYPO3com voted on patch set 1 V +1 08/16/18, 21:30 Completed build in 08m 57s on Thu, 16 Aug, 11:30 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26695

  3. Georg Ringer commented on patch set 1 V +1 CR +1 08/17/18, 08:02

    BackendLayoutView.php:356

    just remove the line, we have the PHPstorm plugin for that
  4. Jan Helke commented on patch set 1 08/17/18, 08:31

    BackendLayoutView.php:356 Reply

    As I am aware that not everybody uses PHPstorm, I won't see that as a blocker and will merge the patch.
  5. Jan Helke voted on patch set 1 V +2 CR +2 08/17/18, 08:32

  6. Jan Helke merged patch set 2 08/17/18, 08:32

  7. Oliver Hader commented on patch set 2 08/20/18, 10:58

    The back-port to v8 seems to be missing...
  8. Jan Helke commented on patch set 2 08/20/18, 12:52

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit e39e8f2165f209626686686ccf844f683068fe60