Review main Merged

57940[TASK] Centralize sending HTTP headers in TSFE

Benni Mack CR +2 V +2 Easy +21 −11 updated 08/17/18, 08:10

Commit message

This patch marks the last change of reordering
sending HTTP response headers via TSFE via
header(), sending all headers within TSFE->processOutput().

Once centralized, the headers can now put into a
PSR-7 response object, if wanted.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Frank Nägler +1
  • Verified V +2
    • Georg Ringer +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 08/17/18, 05:40

  2. TYPO3com voted on patch set 1 V -1 08/17/18, 05:47 Completed build in 07m 32s on Fri, 17 Aug, 07:47 AM Test Summary: 2120 of 35022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26702

  3. Benni Mack uploaded patch set 2 08/17/18, 06:33

  4. TYPO3com voted on patch set 2 V +1 08/17/18, 06:47 Completed build in 12m 34s on Fri, 17 Aug, 08:47 AM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26707

  5. Frank Nägler voted on patch set 2 CR +1 08/17/18, 07:31

  6. Frank Nägler voted on patch set 2 V +1 08/17/18, 07:37

  7. Georg Ringer voted on patch set 2 V +1 CR +1 08/17/18, 08:10

  8. Georg Ringer voted on patch set 2 V +2 CR +2 08/17/18, 08:10

  9. Georg Ringer merged patch set 3 08/17/18, 08:10