57941[TASK] Deprecate PageGenerator class
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Christian Kuhn +1
- Mathias Brodala +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+32 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85822-DeprecatePageGeneratorrenderContent.rstdeleted+0 −36
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85822-PageGenerator.rst1new+40 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php8+887 −17
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+5 −0
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.phpcopied+23 −34
- typo3/sysext/frontend/Tests/UnitDeprecated/Page/PageGeneratorTest.phprenamed+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+15 −1
Review log 2836
Show 711 earlier messages
-
Benni Mack uploaded patch set 1 08/17/18, 05:50
-
Benni Mack commented on patch set 1 CR -1 08/17/18, 05:50
RST is still missing -
TYPO3com voted on patch set 1 V -1 08/17/18, 05:57 Completed build in 07m 01s on Fri, 17 Aug, 07:57 AM Test Summary: 90 of 35022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26703
-
Benni Mack uploaded patch set 2 08/17/18, 06:31
-
Benni Mack updated the commit message in patch set 3 08/17/18, 06:32
-
TYPO3com voted on patch set 2 V -1 08/17/18, 06:42 Completed build in 10m 21s on Fri, 17 Aug, 08:42 AM Test Summary: 3 of 35038 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26705
-
TYPO3com voted on patch set 3 V -1 08/17/18, 06:45 Completed build in 10m 12s on Fri, 17 Aug, 08:45 AM Test Summary: 3 of 35038 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26706
-
Benni Mack uploaded patch set 4 08/17/18, 06:54
-
TYPO3com voted on patch set 4 V +1 08/17/18, 07:02 Completed build in 07m 35s on Fri, 17 Aug, 09:02 AM Test Summary: 34876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26708
-
Mathias Brodala commented on patch set 4 08/17/18, 07:26
RequestHandler.php:985This should be moved somewhere else and be public API instead since it has nothing to do with request handling. I for myself use this in one extension to add a JS file to the document at runtime, so nothing which could be done in a custom request handler. -
Benni Mack commented on patch set 4 08/17/18, 07:30
RequestHandler.php:985Replyyup. sounds like something that could go in to "PageRenderer" instead?
-
Mathias Brodala commented on patch set 4 08/17/18, 07:36
RequestHandler.php:985ReplyYes, this definitely fits in the domain of that class. Can you move it? :-) -
Benni Mack uploaded patch set 5 08/17/18, 07:46
-
Benni Mack commented on patch set 5 08/17/18, 07:47
Mathias, I moved that to GeneralUtility, as a) PageRenderer should not write files, but render a Html Page ;) and b) GeneralUtility already includes writeFileToTypo3temp dir, and I think it fits. What'ya think? I'll then add it to RST -
Mathias Brodala commented on patch set 5 08/17/18, 07:50
> Mathias, I moved that to GeneralUtility, as a) PageRenderer should > not write files, but render a Html Page ;) and b) GeneralUtility > already includes writeFileToTypo3temp dir, and I think it fits. > What'ya think? I'll then add it to RST Fine with me if we can bear with GeneralUtility growing again. ;-) -
Benni Mack commented on patch set 5 08/17/18, 07:52
haha, well. if there is a valid use-case, the new methods are way cleaner and shows that it's actually a three liner, as the old method was really stupid API imho. -
TYPO3com voted on patch set 5 V +1 08/17/18, 07:53 Completed build in 06m 47s on Fri, 17 Aug, 09:53 AM Test Summary: 34876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26710
-
Benni Mack commented on patch set 5 08/17/18, 07:53
If you don't mind, I'd add your name+use case to the new methods to explain the necessity of the methods in the doc comments. -
Benni Mack uploaded patch set 6 08/17/18, 08:04
-
TYPO3com voted on patch set 6 V +1 08/17/18, 08:11 Completed build in 07m 21s on Fri, 17 Aug, 10:11 AM Test Summary: 34876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26711
-
Mathias Brodala voted on patch set 6 CR +1 08/17/18, 08:16
-
Markus Klein commented on patch set 6 CR -1 08/17/18, 09:07
GeneralUtility.php:2554hm...? -
Markus Klein commented on patch set 6 08/17/18, 09:09
Deprecation-85822-PageGenerator.rst:37Daniel Siepmann normalized all enumerations in v8 rsts to asterisk recently. moreover it needs an empty line before. -
Markus Klein commented on patch set 6 08/17/18, 09:13
RequestHandler.php:40this sentence does not make sense, something is wrong.RequestHandler.php:195haveRequestHandler.php:198nullable or optional parameter? if nullable then ?SiteLanguage $siteLanguageRequestHandler.php:213trim above so no need to do it twice -
Markus Klein commented on patch set 6 08/17/18, 09:16
RequestHandler.php:223link is dead -
Benni Mack uploaded patch set 7 08/17/18, 09:39
-
Benni Mack commented on patch set 6 08/17/18, 09:39
GeneralUtility.php:2554ReplyI wanted to point out that mathias brodala came up that this previously static method is in use for extensions (and I wanted to write that down that it's useful for someone :)) -
TYPO3com voted on patch set 7 V -1 08/17/18, 09:48 Completed build in 09m 10s on Fri, 17 Aug, 11:48 AM Test Summary: 39 of 35035 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26719
-
Benni Mack commented on patch set 7 CR -1 08/17/18, 09:51
on it -
Benni Mack uploaded patch set 8 08/17/18, 09:56
-
TYPO3com voted on patch set 8 V +1 08/17/18, 10:05 Completed build in 09m 08s on Fri, 17 Aug, 12:05 PM Test Summary: 34876 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26724
-
Christian Kuhn voted on patch set 8 V +1 CR +1 08/17/18, 10:14
-
Wouter Wolters voted on patch set 8 CR +1 08/17/18, 10:16
-
Mathias Brodala voted on patch set 8 CR +1 08/17/18, 10:21
-
Anja Leichsenring voted on patch set 8 V +2 CR +2 08/17/18, 10:37
-
Anja Leichsenring merged patch set 9 08/17/18, 10:37