Review main Merged

57944[BUGFIX] Ensure cObj only contains valid property objects

Benni Mack CR +2 V +2 Easy +7 −9 updated 08/17/18, 10:32

Commit message

If a cObj instance is serialized (which happens very often), all sub-objects are
serialized with it.

This has a bad side-effect with Logging (as we've seen in other places like scheduler tasks)
when a logger with a FileWriter (to a resource pointer) is used, as the __wakeup() basically
destroys everything.

Therefore the logger is instantiated separately in __wakeup() - the same behaviour
as done with TSFE in ContentObjectRenderer.

Additionally, in order to improve memory footprint, the MarkerBasedTemplateService
is only instantiated whenever used (and not serialized).

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stephan Großberndt +1
    • Christian Kuhn +1
    • Mathias Brodala +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 08/17/18, 09:49

  2. Mathias Brodala voted on patch set 1 CR +1 08/17/18, 09:56

  3. TYPO3com voted on patch set 1 V +1 08/17/18, 09:59 Completed build in 09m 35s on Fri, 17 Aug, 11:59 AM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26722

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/17/18, 10:22

  5. Stephan Großberndt voted on patch set 1 CR +1 08/17/18, 10:28

  6. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/17/18, 10:32

  7. Anja Leichsenring merged patch set 2 08/17/18, 10:32