57948[TASK] Fix spelling and streamline @deprecated notations
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 31
- typo3/sysext/adminpanel/Classes/View/AdminPanelView.php1+1 −2
- typo3/sysext/backend/Classes/Module/AbstractModule.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+1 −0
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −2
- typo3/sysext/backend/Classes/View/PageLayoutView.php+1 −1
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+7 −7
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/IO/PharStreamWrapper.php+1 −1
- typo3/sysext/core/Classes/Package/PackageManager.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+1 −1
- typo3/sysext/core/Classes/Resource/Utility/BackendUtility.php+1 −1
- typo3/sysext/core/Classes/Service/AbstractService.php+1 −1
- typo3/sysext/core/Classes/Utility/ClientUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+8 −8
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/Argument.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/Arguments.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+7 −7
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php+10 −10
Show 11 more files
- typo3/sysext/extbase/Classes/Validation/Validator/RawValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AbstractValidatorTestcase.php+4 −4
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+1 −1
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+3 −3
- typo3/sysext/filelist/Classes/FileFacade.php+1 −1
- typo3/sysext/fluid/Migrations/Code/ClassAliasMap.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+6 −6
- typo3/sysext/frontend/Classes/Page/PageRepository.php+1 −1
- typo3/sysext/install/Classes/Service/CoreUpdateService.php+1 −1
- typo3/sysext/install/Classes/Service/CoreVersionService.php+4 −4
Review log 68
-
Wouter Wolters uploaded patch set 1 08/17/18, 12:27
-
TYPO3com voted on patch set 1 V -1 08/17/18, 12:34 Completed build in 07m 35s on Fri, 17 Aug, 02:34 PM Test Summary: 34808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26736
-
Stephan Großberndt commented on patch set 1 08/17/18, 12:40
17-Aug-2018 14:30:04 PhantomJS not found on PATH 17-Aug-2018 14:30:04 Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2 17-Aug-2018 14:30:04 Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 17-Aug-2018 14:30:04 Receiving... 17-Aug-2018 14:30:04 17-Aug-2018 14:30:04 Error making request. 17-Aug-2018 14:30:04 Error: connect ETIMEDOUT 54.231.32.99:443 17-Aug-2018 14:30:04 at Object._errnoException (util.js:1022:11) 17-Aug-2018 14:30:04 at _exceptionWithHostPort (util.js:1044:20) 17-Aug-2018 14:30:04 at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1198:14) 17-Aug-2018 14:30:04 17-Aug-2018 14:30:04 Please report this full log at https://github.com/Medium/phantomjs Just restart build? -
TYPO3com voted on patch set 1 V +1 08/17/18, 13:01 Completed build in 41m 28s on Fri, 17 Aug, 03:01 PM Test Summary: 34879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26736
-
Benni Mack commented on patch set 1 08/17/18, 13:19
AdminPanelView.php:218I would call all of them "Will be removed in TYPO3 v10.0." as the info that this is deprecated is already done with E_USER_DEPRECATED. I had this clean up task on my list as well, and noted, that I'd like to have a "." at every trigger_error() message as well. -
Benni Mack voted on patch set 1 V +1 CR +1 08/18/18, 20:09
-
Christian Kuhn voted on patch set 1 V +2 CR +2 08/19/18, 08:06
-
Christian Kuhn merged patch set 2 08/19/18, 08:06