Review main Merged

57948[TASK] Fix spelling and streamline @deprecated notations

Wouter Wolters CR +2 V +2 Normal +78 −78 updated 08/19/18, 08:06

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 31

Show 11 more files

Review log 68

  1. Wouter Wolters uploaded patch set 1 08/17/18, 12:27

  2. TYPO3com voted on patch set 1 V -1 08/17/18, 12:34 Completed build in 07m 35s on Fri, 17 Aug, 02:34 PM Test Summary: 34808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26736

  3. Stephan Großberndt commented on patch set 1 08/17/18, 12:40

    17-Aug-2018 14:30:04 PhantomJS not found on PATH 17-Aug-2018 14:30:04 Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2 17-Aug-2018 14:30:04 Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 17-Aug-2018 14:30:04 Receiving... 17-Aug-2018 14:30:04 17-Aug-2018 14:30:04 Error making request. 17-Aug-2018 14:30:04 Error: connect ETIMEDOUT 54.231.32.99:443 17-Aug-2018 14:30:04 at Object._errnoException (util.js:1022:11) 17-Aug-2018 14:30:04 at _exceptionWithHostPort (util.js:1044:20) 17-Aug-2018 14:30:04 at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1198:14) 17-Aug-2018 14:30:04 17-Aug-2018 14:30:04 Please report this full log at https://github.com/Medium/phantomjs Just restart build?
  4. TYPO3com voted on patch set 1 V +1 08/17/18, 13:01 Completed build in 41m 28s on Fri, 17 Aug, 03:01 PM Test Summary: 34879 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26736

  5. Benni Mack commented on patch set 1 08/17/18, 13:19

    AdminPanelView.php:218

    I would call all of them "Will be removed in TYPO3 v10.0." as the info that this is deprecated is already done with E_USER_DEPRECATED. I had this clean up task on my list as well, and noted, that I'd like to have a "." at every trigger_error() message as well.
  6. Benni Mack voted on patch set 1 V +1 CR +1 08/18/18, 20:09

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 08/19/18, 08:06

  8. Christian Kuhn merged patch set 2 08/19/18, 08:06