Review main Merged

57961[TASK] Remove unused protected getter

Benni Mack CR +2 V +2 Easy +0 −11 updated 08/20/18, 11:39

Commit message

The felogin plugin implements a protected short-hand getter
"getTypoScriptFrontendController" although this is never used.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 08/20/18, 05:25

  2. TYPO3com voted on patch set 1 V +1 08/20/18, 05:34 Completed build in 08m 52s on Mon, 20 Aug, 07:34 AM Test Summary: 34905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26805

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 08/20/18, 11:25

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 08/20/18, 11:39

  5. Wouter Wolters merged patch set 2 08/20/18, 11:39