Review main Abandoned

57962[WIP][TASK] Use the current request object in Frontend redirect handling

Benni Mack CR 0 V 0 Easy +37 −13 updated 08/30/18, 13:23

Commit message

The new middleware (introduced in May) for checking against shortcut, mountpoint
and external URL based pages now hands in a ServerRequest object to fetch
the GET variables there.

As this could be breaking, since extensions like RealURL could overwrite GET
parameters, this patch should have the ServerRequest added to "mergingWithGetVars"
first.

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 23

  1. Benni Mack uploaded patch set 1 08/20/18, 06:38

  2. TYPO3com voted on patch set 1 V +1 08/20/18, 06:50 Completed build in 11m 36s on Mon, 20 Aug, 08:50 AM Test Summary: 34905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26807

  3. Benni Mack abandoned the change 08/30/18, 13:23

    not necessary anymore