Review main Merged

57986[TASK] Use suggestedInsertUids feature for new version placeholders

Oliver Hader CR +2 V +2 Easy +1 −1 updated 08/22/18, 10:26

Commit message

The DataHandler::$suggestedInsertUids feature is currently only used
for regular live records, however not for new version placeholders -
which in fact are the pendant for a regular live records, with the
additional binding to a specific workspace context.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Gorges +1
  • Verified V +2
    • Benni Mack +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Oliver Hader uploaded patch set 1 08/22/18, 09:19

  2. Markus Klein commented on patch set 1 08/22/18, 09:28

    DataHandler.php:1254

    the suggestedUId thing is admin-only. does this cause any issues here for normal users?
  3. TYPO3com voted on patch set 1 V +1 08/22/18, 09:32 Completed build in 12m 53s on Wed, 22 Aug, 11:32 AM Test Summary: 34905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26872

  4. Oliver Hader commented on patch set 1 08/22/18, 09:49

    DataHandler.php:1254 Reply

    No, that feature is only used (and useful) when importing records. Regular non-admin users don't have to possibility to define these values (which is good!)
  5. Daniel Gorges voted on patch set 1 V +1 CR +1 08/22/18, 10:07

  6. Benni Mack commented on patch set 1 V +2 CR +2 08/22/18, 10:23

    makes sense.
  7. Oliver Hader merged patch set 2 08/22/18, 10:26