Review main Merged

57990[TASK] Add resolved site object to FormEngine

Christian Kuhn CR +2 V +2 Normal +162 −20 updated 08/22/18, 17:07

Commit message

With pseudo sites we now always have a site object in backend.
The site object is needed multiple times in FormEngine, the
upcoming slug handling adds another usage.
The patch adds a FormEngine data provider to resolve the
site object for any given page or record and adds it as 'site'
to the result array.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 79

  1. Christian Kuhn uploaded patch set 1 08/22/18, 16:03

  2. TYPO3com voted on patch set 1 V +1 08/22/18, 16:22 Completed build in 18m 13s on Wed, 22 Aug, 06:22 PM Test Summary: 35556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26897

  3. Christian Kuhn voted on patch set 1 CR -1 08/22/18, 16:27

  4. Christian Kuhn uploaded patch set 2 08/22/18, 16:31

  5. TYPO3com voted on patch set 2 V +1 08/22/18, 16:43 Completed build in 12m 09s on Wed, 22 Aug, 06:43 PM Test Summary: 35556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26901

  6. Benni Mack voted on patch set 2 V +1 CR +1 08/22/18, 16:44

  7. Andreas Kienast commented on patch set 2 CR -1 08/22/18, 16:59

    on it
  8. Andreas Kienast voted on patch set 2 V +2 CR +2 08/22/18, 17:07

  9. Andreas Kienast merged patch set 3 08/22/18, 17:07