57998[FEATURE] Make icon size configurable in FormControl
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 34
-
Stefan Froemken uploaded patch set 1 08/23/18, 08:56
-
TYPO3com voted on patch set 1 V +1 08/23/18, 09:10 Completed build in 14m 25s on Thu, 23 Aug, 11:10 AM Test Summary: 35556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26930
-
Christian Kuhn commented on patch set 1 CR -1 08/23/18, 09:28
First: Not for v8, master only. Apart from that, I'm unsure if we should do that: The small icon size fits to the casual input field sizes. Having bigger icons here on field control level easily looks funny. I added a scrennshot to the issue to show that. This renders this option useful only for own elements, since otherwise it most likely looks ugly. If that is the case, the question raises on why the field control is used for such an own element in the first place, it might be easier to just integrate the button into the element directly without the field control to gain full freedom on the html. Could you elaborate a bit on your use case, Stefan? -
Stefan Froemken abandoned the change 08/23/18, 10:33
In my case the class btn was not interpreted, because of the missing white-space in default CSS of FieldControl. Without interpreted btn class Icon::SIZE_DEFAULT looks much better. As you just have implemented my other patch you're right and icon size should not be editable. I have abandoned this patch.