58003[BUGFIX] Mitigate deprecations in early bootstrap
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1418
-
Helmut Hummel uploaded patch set 1 08/23/18, 11:55
-
TYPO3com voted on patch set 1 V -1 08/23/18, 11:55 Completed build in 10s on Thu, 23 Aug, 01:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26951
-
Helmut Hummel uploaded patch set 2 08/23/18, 11:55
-
Helmut Hummel uploaded patch set 3 08/23/18, 12:01
-
TYPO3com voted on patch set 2 V +1 08/23/18, 12:07 Completed build in 11m 05s on Thu, 23 Aug, 02:07 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26952
-
TYPO3com voted on patch set 3 V +1 08/23/18, 12:20 Completed build in 17m 01s on Thu, 23 Aug, 02:20 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26955
-
Helmut Hummel uploaded patch set 4 08/23/18, 12:20
-
Wouter Wolters voted on patch set 4 CR +1 08/23/18, 12:22
-
Christian Kuhn commented on patch set 4 08/23/18, 12:23
i think next time we "deprecate" @internal marked methods, i'd opt to remove them right away. -
TYPO3com voted on patch set 4 V +1 08/23/18, 12:30 Completed build in 09m 31s on Thu, 23 Aug, 02:30 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26957
-
Helmut Hummel commented on patch set 4 08/23/18, 12:42
I cannot say much about other cases for using internal bootstrap API except TYPO3 Console. However I would argue that this is legit. Keeping the deprecated methods around does not harm the core much except for the beauty of the code. Removing them (or triggering errors early on) however would make it very hard to keep support for the current TYPO3 version without removing support for older ones. That in consequence would make the maintenance of that tool much much harder than it could be. So while I agree on removing/changing internal marked methods in general, in this case I consider it a good decision to keep them because the result is/was that a compatible console version was/is available with the release of every "stable" TYPO3 version 9. -
Christian Kuhn commented on patch set 4 08/23/18, 13:22
well, at least 4 possisble solutions come to my mind to handle such cases in your extension: * add a version_compare to your code * fork your extension for specific cores * check with methods_exists or similar before calling * wrap the calls in some prepared error setup to suppress the deprecations so there are plenty of options to deal with that even if we would remove the internal marked methods. -
Helmut Hummel commented on patch set 4 08/23/18, 13:30
> add a version_compare to your code That is already in place, but requires quite a bit of work for bootstrap related code > fork your extension for specific cores That requires even more work especially when wanting to ship features across branches, which is quite benefitial for users > check with methods_exists or similar before calling also in place but same as above: requires work and time > wrap the calls in some prepared error setup to suppress the deprecations That is what can be done, and I have prepared here: https://github.com/TYPO3-Console/TYPO3-Console/pull/741/files My question though is: What is the benefit for the overall product to keep these deprecation messages/errors in place? I don't see one, but maybe I miss something. -
Christian Kuhn commented on patch set 4 08/23/18, 13:51
i'm only saying that since (most) of those methods are @internal, you are using them on your own risk. to mitigate the trouble on our side, i'd prefer to remove such things directly next time without any deprecation notices. -
Helmut Hummel commented on patch set 4 08/23/18, 14:05
> you are using them on your own risk. to mitigate the trouble on our side, i'd prefer to remove such things directly next time without any deprecation notices. In general I agree. However, I'm not using this API because I'm lazy, but to create a major benefit for the product, which would otherwise not be possible. I found it very helpful and supportive that the API still worked after a major bootstrap refactoring and it only stopped working with a tiny change that added these messages. Triggering these messages are similarly breaking than just removing these methods. So I thought instead of just fixing my code, I'd gone one step further and fix it for other legitimate usages of internal API, which I might not be aware of. Being breaking here can of course be seen as reasonable. It is just less helpful and less supportive. -
Benni Mack voted on patch set 4 V +1 CR +1 08/23/18, 15:33
-
Georg Ringer voted on patch set 4 V +2 CR +2 08/23/18, 17:02
-
Georg Ringer merged patch set 5 08/23/18, 17:02