58005[BUGFIX] Use runtime cache for getIndpEnv() for results which are NULL
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 2
Files 3
Review log 1619
-
Michael Stucki uploaded patch set 1 08/23/18, 13:49
-
Michael Stucki updated the commit message in patch set 2 08/23/18, 13:50
-
Michael Stucki wrote 08/23/18, 13:59
Topic set to 85946 -
TYPO3com voted on patch set 1 V -1 08/23/18, 14:00 Completed build in 10m 53s on Thu, 23 Aug, 04:00 PM Test Summary: 6 of 35523 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26963
-
TYPO3com voted on patch set 2 V -1 08/23/18, 14:02 Completed build in 11m 33s on Thu, 23 Aug, 04:02 PM Test Summary: 6 of 35523 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26964
-
Michael Stucki commented on patch set 2 08/23/18, 14:52
It seems like this breaks unit tests. I'll come up with a suggestion to fix this. -
Michael Stucki commented on patch set 2 08/23/18, 15:08
-
Markus Klein commented on patch set 2 08/24/18, 08:22
In which case do we have NULL values in getIndpEnv? Aren't we only dealing with strings here? -
Michael Stucki commented on patch set 2 08/24/18, 08:28
Markus: This seems to happen quite often in CLI scripts. For example, check HTTP_HOST. -
Markus Klein commented on patch set 2 08/24/18, 09:54
Good point. Even though a cli script shouldn't do anything which requires a HTTP env, or it has to set up things correctly (which is cumbersome, I know from real life ;-) ) -
Markus Klein commented on patch set 2 08/27/18, 23:18
This breaks the tests because now the null value is cached and therefore the tests can't feed in their testdata. (cache is filled before this happens) This is only solveable by either adding a cache-flush method for this internal cache, or by not applying this patch at all -
Christian Kuhn uploaded patch set 3 09/02/18, 12:12
-
Christian Kuhn commented on patch set 3 09/02/18, 12:13
fixed the tests and removed 7.6 from releases (imho not critical and a bit risky on this low level). -
TYPO3com voted on patch set 3 V +1 09/02/18, 12:22 Completed build in 09m 27s on Sun, 2 Sep, 02:22 PM Test Summary: 35941 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27552
-
Christian Kuhn voted on patch set 3 V +1 CR +1 09/02/18, 12:44
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 09/02/18, 12:49
-
Christian Kuhn voted on patch set 3 V +2 CR +2 09/02/18, 12:54
-
Christian Kuhn merged patch set 4 09/02/18, 12:54
-
Michael Stucki commented on patch set 4 09/02/18, 23:02
Thanks a lot for finishing this change, Christian!