Review TYPO3_8-7 Merged

58006[BUGFIX] Use runtime cache for getIndpEnv() for results which are NULL

Michael Stucki CR +2 V +2 Easy +3 −1 updated 09/02/18, 13:33

Commit message

isset() returns FALSE if a cached result is NULL.
Use array_key_exists() instead.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 2

Files 3

Review log 710

  1. Michael Stucki uploaded patch set 1 08/23/18, 13:59

  2. Michael Stucki wrote 08/23/18, 14:00

    Topic set to 85946
  3. TYPO3com voted on patch set 1 V -1 08/23/18, 14:09 Completed build in 10m 08s on Thu, 23 Aug, 04:09 PM Test Summary: 12 of 59833 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2892

  4. Christian Kuhn updated the commit message in patch set 2 09/02/18, 12:14

  5. Christian Kuhn commented on patch set 2 09/02/18, 12:14

    needs update if master is merged.
  6. TYPO3com voted on patch set 2 V -1 09/02/18, 12:23 Completed build in 09m 28s on Sun, 2 Sep, 02:23 PM Test Summary: 12 of 59833 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2910

  7. Christian Kuhn uploaded patch set 3 09/02/18, 12:58

  8. TYPO3com voted on patch set 3 V +1 09/02/18, 13:08 Completed build in 09m 53s on Sun, 2 Sep, 03:08 PM Test Summary: 59428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2912

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 09/02/18, 13:33

  10. Christian Kuhn merged patch set 4 09/02/18, 13:33