Review main Merged

58010[TASK] Improved slug generation for translated pages

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 08/23/18, 19:44

Commit message

If a slug is generated for a nested translated page that
has a not translated page up in its rootline, the slug
generator now considers the default language page instead
of not including the upper tree pages at all.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Richard Haeser +1
  • Verified V +2
    • Benni Mack +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 08/23/18, 18:35

  2. TYPO3com voted on patch set 1 V +1 08/23/18, 18:44 Completed build in 09m 43s on Thu, 23 Aug, 08:44 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26982

  3. Christian Kuhn updated the commit message in patch set 2 08/23/18, 19:06

  4. Benni Mack voted on patch set 2 CR +1 08/23/18, 19:07

  5. Wouter Wolters voted on patch set 2 CR +1 08/23/18, 19:09

  6. TYPO3com voted on patch set 2 V +1 08/23/18, 19:17 Completed build in 11m 13s on Thu, 23 Aug, 09:17 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26985

  7. Benni Mack voted on patch set 2 V +1 08/23/18, 19:24

  8. Richard Haeser voted on patch set 2 V +1 CR +1 08/23/18, 19:43

  9. Benni Mack voted on patch set 2 V +2 CR +2 08/23/18, 19:43

  10. Benni Mack merged patch set 3 08/23/18, 19:44