Review main Merged

58013[TASK] Disable slug in pseudo sites and disable alias in sites

Christian Kuhn CR +2 V +2 Normal +87 −2 updated 10/25/18, 10:53

Commit message

Slug handling does now work if using pseudo sites. The patch adds
a display condition to form engine to hide the field if the edited
page is within page tree that resolves to a pseudo site.

Additionally, the 'alias' pages db field is a poor-man redirect
solution that should be outphased in v9. It is currently not resolved
if using configured sites at all. The patch turns the display condition
around for that to hide the field if a page that resolves to a proper
site object is edited.

A change in InputSlugElement that leads to wrongly resolved
languages if editing pages is fixed along the way.

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Wolf +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1114

  1. Christian Kuhn uploaded patch set 1 08/23/18, 20:54

  2. TYPO3com voted on patch set 1 V +1 08/23/18, 21:03 Completed build in 09m 09s on Thu, 23 Aug, 11:03 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26994

  3. Christian Kuhn uploaded patch set 2 08/23/18, 21:04

  4. TYPO3com voted on patch set 2 V +1 08/23/18, 21:13 Completed build in 09m 26s on Thu, 23 Aug, 11:13 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26995

  5. Wouter Wolters voted on patch set 2 CR +1 08/23/18, 21:34

  6. Andreas Kienast uploaded patch set 3 08/25/18, 08:22

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 08/25/18, 08:22

  8. TYPO3com voted on patch set 3 V +1 08/25/18, 08:32 Completed build in 09m 20s on Sat, 25 Aug, 10:32 AM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27062

  9. Andreas Wolf commented on patch set 3 V +2 08/25/18, 09:21

    Not merging because I want to solve the question I raised about method naming, apart from that this is ready to merge.

    PseudoSiteTcaDisplayCondition.php:64

    Would it probably be clever to just name the check "isNotInRealSite" then?
  10. Wouter Wolters voted on patch set 3 CR +1 08/25/18, 09:49

  11. Christian Kuhn commented on patch set 3 08/27/18, 12:23

    PseudoSiteTcaDisplayCondition.php:64 Reply

    i'd like to avoid the 'Not' in the method name and 'is pseudo' pretty much nails it, even if the implementation reacts to 'Site' only. Do you have a suggestion for a better methods name that does not include 'not' ? Also, this is temporary code, and keeping word 'pseudo' in the method name will probably make it a bit easier to spot and remove this part in v10. I'm undecided, but in the end this is not a critical decision, imho. We could just keep and not kitten would be harmed, i guess ;)
  12. Benni Mack voted on patch set 3 V +2 CR +2 08/30/18, 05:43

  13. Benni Mack merged patch set 4 08/30/18, 05:43

  14. Daniel Goerz commented on patch set 4 10/25/18, 10:53