58013[TASK] Disable slug in pseudo sites and disable alias in sites
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Wouter Wolters +1
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Andreas Wolf +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1114
-
Christian Kuhn uploaded patch set 1 08/23/18, 20:54
-
TYPO3com voted on patch set 1 V +1 08/23/18, 21:03 Completed build in 09m 09s on Thu, 23 Aug, 11:03 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26994
-
Christian Kuhn uploaded patch set 2 08/23/18, 21:04
-
TYPO3com voted on patch set 2 V +1 08/23/18, 21:13 Completed build in 09m 26s on Thu, 23 Aug, 11:13 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26995
-
Wouter Wolters voted on patch set 2 CR +1 08/23/18, 21:34
-
Andreas Kienast uploaded patch set 3 08/25/18, 08:22
-
Andreas Kienast voted on patch set 3 V +1 CR +1 08/25/18, 08:22
-
TYPO3com voted on patch set 3 V +1 08/25/18, 08:32 Completed build in 09m 20s on Sat, 25 Aug, 10:32 AM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27062
-
Andreas Wolf commented on patch set 3 V +2 08/25/18, 09:21
Not merging because I want to solve the question I raised about method naming, apart from that this is ready to merge.PseudoSiteTcaDisplayCondition.php:64Would it probably be clever to just name the check "isNotInRealSite" then? -
Wouter Wolters voted on patch set 3 CR +1 08/25/18, 09:49
-
Christian Kuhn commented on patch set 3 08/27/18, 12:23
PseudoSiteTcaDisplayCondition.php:64Replyi'd like to avoid the 'Not' in the method name and 'is pseudo' pretty much nails it, even if the implementation reacts to 'Site' only. Do you have a suggestion for a better methods name that does not include 'not' ? Also, this is temporary code, and keeping word 'pseudo' in the method name will probably make it a bit easier to spot and remove this part in v10. I'm undecided, but in the end this is not a critical decision, imho. We could just keep and not kitten would be harmed, i guess ;) -
Benni Mack voted on patch set 3 V +2 CR +2 08/30/18, 05:43
-
Benni Mack merged patch set 4 08/30/18, 05:43
-
Daniel Goerz commented on patch set 4 10/25/18, 10:53
Regression: https://review.typo3.org/#/c/58696/