Review main Merged

58018[TASK] Remove a series of SOBE assignments

Christian Kuhn CR +2 V +2 Easy +0 −7 updated 08/24/18, 07:03

Commit message

The infamous $GLOBALS['SOBE'] object is still used at various
places is the core. This "talk to the hand" object registered
as runtime global to make itself available as "parent object"
is an even worse anti pattern than the also infamous $pObj.

The patch removes a series of "$GLOBALS['SOBE'] = $this" assignments
in some controllers that have no further dependency to this global
anymore for a while, are easy to review and b/w compatible.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 68

  1. Christian Kuhn uploaded patch set 1 08/23/18, 23:28

  2. Christian Kuhn updated the commit message in patch set 2 08/23/18, 23:29

  3. TYPO3com voted on patch set 1 V +1 08/23/18, 23:38 Completed build in 09m 55s on Fri, 24 Aug, 01:38 AM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27003

  4. TYPO3com voted on patch set 2 V +1 08/23/18, 23:39 Completed build in 10m 03s on Fri, 24 Aug, 01:39 AM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27004

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 08/24/18, 06:00

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 08/24/18, 06:00

  7. Wouter Wolters voted on patch set 2 V +2 CR +2 08/24/18, 07:03

  8. Wouter Wolters merged patch set 3 08/24/18, 07:03