Review main Merged

58020[TASK] Deprecate authentication related compareUident() method

Christian Kuhn CR +2 V +2 Normal +55 −0 updated 08/24/18, 06:58

Commit message

The patch deprecates the unused compareUident() from
AbstractAuthenticationService that calls the also unused method
with the same name from AbstractUserAuthentication.

The code is dead left over stuff from pre password hashing era
and can be safely deprecated now.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 45

  1. Christian Kuhn uploaded patch set 1 08/24/18, 00:00

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 00:10 Completed build in 10m 37s on Fri, 24 Aug, 02:10 AM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27006

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 08/24/18, 06:03

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 08/24/18, 06:58

  5. Wouter Wolters merged patch set 2 08/24/18, 06:58