Review main Merged

58022[TASK] Sort building process within PageLinkBuilder / TypoLink

Benni Mack CR +2 V +2 Easy +26 −24 updated 08/30/18, 12:30

Commit message

This is a pre-cursor for unifying URL generation with slugs / based on sites,
in order to group things that belong together in the mass-method of generating
links in the frontend.

Tasks done:
- $linkText is moved to the very end, as it has no dependency.
- $targetDomain/$currentDomain handling is grouped together.
- absRefPrefix is now always taken from $tsfe->absRefPrefix, as this is the
  resolved path (not set to "auto")
- minor un-needed calls simplified (unneessary checks etc)

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 08/24/18, 14:21

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 14:31 Completed build in 09m 26s on Fri, 24 Aug, 04:31 PM Test Summary: 35289 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27025

  3. Wouter Wolters voted on patch set 1 CR +1 08/25/18, 09:51

  4. Susi Moog voted on patch set 1 CR +1 08/27/18, 11:06

  5. Susi Moog voted on patch set 1 V +1 08/27/18, 11:14

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 08/27/18, 12:44

  7. Christian Kuhn merged patch set 2 08/27/18, 12:44

  8. Oliver Hader commented on patch set 2 08/30/18, 12:30

    PageLinkBuilder.php:185

    Thus, forceAbsoluteUrl has no effect here anymore...