Review main Merged

58023[TASK] Deprecate GraphicalFunctions->init method

Benni Mack CR +2 V +2 Normal +114 −60 updated 08/25/18, 12:27

Commit message

The init method of GraphicalFunctions/Gifbuilder was used instead of
a constructor to set up various internal properties, and is now
shifted into a new constructor, making the extra call to init() superfluous.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 15

Review log 68

  1. Benni Mack uploaded patch set 1 08/24/18, 15:15

  2. TYPO3com voted on patch set 1 V -1 08/24/18, 15:25 Completed build in 10m 00s on Fri, 24 Aug, 05:25 PM Test Summary: 9 of 35526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27028

  3. Wouter Wolters uploaded patch set 2 08/25/18, 12:14

  4. Andreas Kienast voted on patch set 2 CR +1 08/25/18, 12:19

  5. TYPO3com voted on patch set 2 V +1 08/25/18, 12:23 Completed build in 09m 17s on Sat, 25 Aug, 02:23 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27070

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 08/25/18, 12:25

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 08/25/18, 12:27

  8. Andreas Kienast merged patch set 3 08/25/18, 12:27