Review main Merged

58024[TASK] Use strict bool calls for TimeTracker->LR

Benni Mack CR +2 V +2 Easy +2 −2 updated 08/25/18, 09:46

Commit message

The public property "TimeTracker->$LR" is declared as boolean, but used
with integer. Let's have TYPO3 use it that way it was documented.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Georg Ringer +1
  • Verified V +2
    • Wouter Wolters +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack uploaded patch set 1 08/24/18, 15:18

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 15:30 Completed build in 12m 33s on Fri, 24 Aug, 05:30 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27029

  3. Georg Ringer voted on patch set 1 V +1 CR +1 08/24/18, 21:00

  4. Wouter Wolters voted on patch set 1 V +2 CR +2 08/25/18, 09:45

  5. Wouter Wolters merged patch set 2 08/25/18, 09:46