Review main Merged

58026[TASK] Inject TSFE object into ContentObjectRenderer

Benni Mack CR +2 V +2 Easy +2 −2 updated 08/25/18, 12:51

Commit message

The class ContentObjectRenderer expects $typoScriptFrontendController
as first argument inside the constructor.

When creating cObj from within TypoScriptFrontendController, it is very valuable
to actually use the actual current object instead of doing the regular fallback
to $GLOBALS['TSFE'], to use this in proper recursions.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack uploaded patch set 1 08/24/18, 15:27

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 15:37 Completed build in 09m 27s on Fri, 24 Aug, 05:37 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27031

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 08/25/18, 11:53

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 08/25/18, 12:51

  5. Andreas Kienast merged patch set 2 08/25/18, 12:51