58028[TASK] Deprecate cObject FILE
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1014
-
Benni Mack uploaded patch set 1 08/24/18, 16:14
-
TYPO3com voted on patch set 1 V +1 08/24/18, 16:26 Completed build in 11m 57s on Fri, 24 Aug, 06:26 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27033
-
Anja Leichsenring rebased onto patch set 2 09/07/18, 20:34
-
Anja Leichsenring uploaded patch set 3 09/07/18, 20:34
-
TYPO3com voted on patch set 2 V +1 09/07/18, 20:44 Completed build in 10m 37s on Fri, 7 Sep, 10:44 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27888
-
TYPO3com voted on patch set 3 V +1 09/07/18, 20:47 Completed build in 12m 32s on Fri, 7 Sep, 10:47 PM Test Summary: 35863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27889
-
Benni Mack commented on patch set 3 09/07/18, 22:08
please add a ExtensionScanner to file, and add an information (// @deprecated comment) where FILE is registered (which is in ext_localconf.php of EXT:frontend). Otherwise good then! -
Benni Mack commented on patch set 3 09/07/18, 22:11
Deprecation-85970-DeprecateCObjectFILE.rst:1please rename the file to Deprecation-...-FileContentObject.rstDeprecation-85970-DeprecateCObjectFILE.rst:4remove "Deprecate " - I know we haven't consistently done this in the past, but I tried to avoid double Deprecate/Deprecation in the headline in the last 2 months on my deprecations.Deprecation-85970-DeprecateCObjectFILE.rst:12would remove the "strange behaviour", better "is mixing concerns (rendering an image, or dumping file contents)Deprecation-85970-DeprecateCObjectFILE.rst:19Just leave "Fluid offers more flexibility nowadays"Deprecation-85970-DeprecateCObjectFILE.rst:22.. "however due to the flexibility... " and everything after that goes to the Migration section. You can rewrite the sentence of course. Also add a snippet (e.g. taken from EXT:frontend/ext_localconf.php) on how to register a custom cObject again - for the sake of being nice to developers (pretty please). -
Chris topher commented on patch set 3 09/08/18, 12:50
What is the replacement, if the file content should be used? E.g. how should a file be added to the TEMPLATE cObject in the future? 10 = TEMPLATE 10.template = FILE 10.template.file = fileadmin/template.html How should this be realized? => This should still be added to the rst file! -
Anja Leichsenring uploaded patch set 4 09/10/18, 18:34
-
Anja Leichsenring voted on patch set 4 V +1 CR +1 09/10/18, 18:35
-
TYPO3com voted on patch set 4 V +1 09/10/18, 18:44 Completed build in 09m 18s on Mon, 10 Sep, 08:44 PM Test Summary: 35869 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27958
-
Christian Kuhn voted on patch set 4 V +2 CR +2 09/10/18, 22:03
-
Christian Kuhn merged patch set 5 09/10/18, 22:05