Review main Merged

58029[TASK] Deprecate PageRepository->getFirstWebPage()

Benni Mack CR +2 V +2 Easy +46 −2 updated 08/25/18, 12:48

Commit message

The method PageRepository->getFirstWebPage() is only used when
no "?id" parameter is given, and no rootpage was resolved. As this is the only
use-case, a more generic "getMenu" method can be used, which does the
same except for not "limiting" the query to one result, so there is a minimal
memory penalty when doing so, however due to Pseudo-Site functionality
this drawback is only in use for rare cases.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 4

Review log 69

  1. Benni Mack uploaded patch set 1 08/24/18, 16:18

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 16:30 Completed build in 11m 04s on Fri, 24 Aug, 06:30 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27034

  3. Wouter Wolters uploaded patch set 2 08/25/18, 12:25

  4. Wouter Wolters uploaded patch set 3 08/25/18, 12:29

  5. TYPO3com voted on patch set 2 V +1 08/25/18, 12:38 Completed build in 12m 22s on Sat, 25 Aug, 02:38 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27071

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 08/25/18, 12:40

  7. Wouter Wolters voted on patch set 3 V +2 CR +2 08/25/18, 12:42

  8. Wouter Wolters merged patch set 4 08/25/18, 12:42

  9. TYPO3com voted on patch set 3 V +1 08/25/18, 12:48 Completed build in 17m 17s on Sat, 25 Aug, 02:48 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27074