Review main Merged

58031[BUGFIX] Throw exception in case FileWriter's logFile is invalid

Oliver Hader CR +2 V +2 Easy +1 −1 updated 08/25/18, 11:44

Commit message

GeneralUtility::getFileAbsFileName($logFile) never results in `null`,
but in some empty string in case the $logFile is invalid.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Oliver Hader uploaded patch set 1 08/24/18, 16:27

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 16:36 Completed build in 09m 20s on Fri, 24 Aug, 06:36 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27036

  3. Markus Klein voted on patch set 1 V +1 CR +1 08/24/18, 16:39

  4. Wouter Wolters voted on patch set 1 CR +1 08/24/18, 16:46

  5. Wouter Wolters voted on patch set 1 V +2 CR +2 08/25/18, 11:44

  6. Wouter Wolters merged patch set 2 08/25/18, 11:44