Review main Merged

58032[TASK] Extend blog_example with relations

Tymoteusz Motylewski CR +2 V +2 Hard +377 −5 updated 08/30/18, 14:11

Commit message

* 1:1 inline relation csv (Post->additonalName)
* 1:1 inline relation foreign_field (Post->additonalInfo)
* 1:n inline relation csv (Post->additionalComments)
* n:1 group relation (Post->secondAuthor)

It also makes Person model translatable.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
  • Verified V +2
    • Anja Leichsenring +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 2135

Show 710 earlier messages
  1. Tymoteusz Motylewski uploaded patch set 1 08/24/18, 16:59

  2. TYPO3com voted on patch set 1 V -1 08/24/18, 16:59 Completed build in 13s on Fri, 24 Aug, 06:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27037

  3. Tymoteusz Motylewski uploaded patch set 2 08/24/18, 17:02

  4. Markus Klein commented on patch set 1 08/24/18, 17:06

    Post.php:414

    both are optional items, so must be ?Info here

    tx_blogexample_domain_model_post.php:28

    could be removed
  5. Tymoteusz Motylewski uploaded patch set 3 08/24/18, 17:06

  6. Tymoteusz Motylewski uploaded patch set 4 08/24/18, 17:09

  7. Tymoteusz Motylewski uploaded patch set 5 08/24/18, 17:11

  8. TYPO3com voted on patch set 2 V -1 08/24/18, 17:13 Completed build in 10m 45s on Fri, 24 Aug, 07:13 PM Test Summary: 153 of 35526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27038

  9. TYPO3com voted on patch set 3 V -1 08/24/18, 17:18 Completed build in 11m 42s on Fri, 24 Aug, 07:18 PM Test Summary: 153 of 35526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27039

  10. Markus Klein uploaded patch set 6 08/24/18, 17:19

  1. TYPO3com voted on patch set 4 V -1 08/24/18, 17:22 Completed build in 13m 35s on Fri, 24 Aug, 07:22 PM Test Summary: 153 of 35526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27040

  2. TYPO3com voted on patch set 5 V -1 08/24/18, 17:26 Completed build in 13m 59s on Fri, 24 Aug, 07:26 PM Test Summary: 153 of 35526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27041

  3. TYPO3com voted on patch set 6 V -1 08/24/18, 17:29 Completed build in 09m 57s on Fri, 24 Aug, 07:29 PM Test Summary: 153 of 35526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27042

  4. Markus Klein uploaded patch set 7 08/24/18, 17:56

  5. TYPO3com voted on patch set 7 V +1 08/24/18, 18:05 Completed build in 08m 54s on Fri, 24 Aug, 08:05 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27043

  6. Markus Klein updated the commit message in patch set 8 08/24/18, 18:36

  7. TYPO3com voted on patch set 8 V +1 08/24/18, 18:45 Completed build in 09m 09s on Fri, 24 Aug, 08:45 PM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27044

  8. Anja Leichsenring uploaded patch set 9 08/25/18, 14:07

  9. TYPO3com voted on patch set 9 V +1 08/25/18, 14:16 Completed build in 09m 30s on Sat, 25 Aug, 04:16 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27086

  10. Łukasz Uznański uploaded patch set 10 08/26/18, 20:23

  11. Łukasz Uznański uploaded patch set 11 08/26/18, 20:33

  12. TYPO3com voted on patch set 10 V +1 08/26/18, 20:33 Completed build in 10m 06s on Sun, 26 Aug, 10:33 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27101

  13. TYPO3com voted on patch set 11 V +1 08/26/18, 20:43 Completed build in 10m 02s on Sun, 26 Aug, 10:43 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27102

  14. Markus Klein commented on patch set 11 08/27/18, 06:21

    tx_blogexample_domain_model_post.php:131

    misses foreign_table => '...person' (that's needed for extbase!)
  15. Markus Klein commented on patch set 12 08/27/18, 06:21

    Published edit on patch set 11.
  16. TYPO3com voted on patch set 12 V +1 08/27/18, 06:32 Completed build in 10m 06s on Mon, 27 Aug, 08:32 AM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27107

  17. Tymoteusz Motylewski updated the commit message in patch set 13 08/30/18, 13:34

  18. Tymoteusz Motylewski commented on patch set 13 CR -1 08/30/18, 13:36

    let me make author translatable
  19. TYPO3com voted on patch set 13 V +1 08/30/18, 13:43 Completed build in 08m 54s on Thu, 30 Aug, 03:43 PM Test Summary: 35334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27309

  20. Tymoteusz Motylewski uploaded patch set 14 08/30/18, 13:44

  21. TYPO3com voted on patch set 14 V +1 08/30/18, 13:54 Completed build in 10m 20s on Thu, 30 Aug, 03:54 PM Test Summary: 35334 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27313

  22. Anja Leichsenring voted on patch set 14 V +1 CR +1 08/30/18, 14:03

  23. Mathias Schreiber voted on patch set 14 V +1 CR +1 08/30/18, 14:04

  24. Anja Leichsenring voted on patch set 14 V +2 CR +2 08/30/18, 14:11

  25. Anja Leichsenring merged patch set 15 08/30/18, 14:11