Review main Merged

58034[TASK] Deprecate TSFE constructor with no_cache parameter

Benni Mack CR +2 V +2 Normal +61 −14 updated 08/28/18, 11:53

Commit message

Instantiating TypoScriptFrontendController with the fourth
parameter set (except null) will now trigger a deprecation
message, as it is recommended to use the method `set_no_cache`
instead.

Review

  • Code review CR +2
    • Susi Moog +2
    • Wouter Wolters +1
    • Daniel Gorges +1
  • Verified V +2
    • Susi Moog +2
    • Daniel Gorges +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 68

  1. Benni Mack uploaded patch set 1 08/24/18, 22:30

  2. TYPO3com voted on patch set 1 V +1 08/24/18, 22:39 Completed build in 08m 52s on Sat, 25 Aug, 12:39 AM Test Summary: 35292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27056

  3. Benni Mack uploaded patch set 2 08/28/18, 06:43

  4. TYPO3com voted on patch set 2 V +1 08/28/18, 06:53 Completed build in 09m 41s on Tue, 28 Aug, 08:53 AM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27164

  5. Wouter Wolters voted on patch set 2 CR +1 08/28/18, 07:21

  6. Daniel Gorges voted on patch set 2 V +1 CR +1 08/28/18, 11:46

  7. Susi Moog voted on patch set 2 V +2 CR +2 08/28/18, 11:53

  8. Susi Moog merged patch set 3 08/28/18, 11:53