Review TYPO3_8-7 Merged

58036[BUGFIX] Throw exception in case FileWriter's logFile is invalid

Wouter Wolters CR +2 V +2 Easy +1 −1 updated 08/25/18, 12:04

Commit message

GeneralUtility::getFileAbsFileName($logFile) never results in `null`,
but in some empty string in case the $logFile is invalid.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Wouter Wolters uploaded patch set 1 08/25/18, 11:49

  2. TYPO3com voted on patch set 1 V +1 08/25/18, 11:56 Completed build in 07m 42s on Sat, 25 Aug, 01:56 PM Test Summary: 59428 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2895

  3. Wouter Wolters voted on patch set 1 V +2 CR +2 08/25/18, 12:04

  4. Wouter Wolters merged patch set 2 08/25/18, 12:04