58042[TASK] Use typo3/phar-stream-wrapper package
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Georg Ringer +1
- Wouter Wolters +1
- Benni Mack +1
-
Verified V +2
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/IO/PharStreamWrapper.phpdeleted+0 −557
- typo3/sysext/core/Classes/IO/PharStreamWrapperException.phpdeleted+0 −20
- typo3/sysext/core/Classes/IO/PharStreamWrapperInterceptor.phpnew+132 −0
- typo3/sysext/core/Migrations/Code/ClassAliasMap.php+2 −0
- typo3/sysext/core/Tests/Functional/IO/PharStreamWrapperInterceptorTest.phprenamed+15 −8
- typo3/sysext/core/composer.json+1 −0
- composer.json+1 −0
- composer.lock+36 −1
Review log 1622
-
Oliver Hader uploaded patch set 1 08/26/18, 20:43
-
TYPO3com voted on patch set 1 V -1 08/26/18, 20:43 Completed build in 09s on Sun, 26 Aug, 10:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27103
-
Oliver Hader uploaded patch set 2 08/26/18, 20:44
-
TYPO3com voted on patch set 2 V -1 08/26/18, 20:54 Completed build in 09m 38s on Sun, 26 Aug, 10:54 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27104
-
Oliver Hader uploaded patch set 3 08/26/18, 21:06
-
TYPO3com voted on patch set 3 V +1 08/26/18, 21:16 Completed build in 09m 31s on Sun, 26 Aug, 11:16 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27105
-
Mathias Brodala commented on patch set 3 08/27/18, 08:14
Would it make sense to move these to a class alias map instead? -
Benni Mack commented on patch set 3 08/28/18, 17:39
please also adjust the composer.json within typo3/sysext/core -
Oliver Hader uploaded patch set 4 08/28/18, 19:20
-
Oliver Hader updated the commit message in patch set 5 08/28/18, 19:24
-
TYPO3com voted on patch set 4 V +1 08/28/18, 19:31 Completed build in 11m 00s on Tue, 28 Aug, 09:31 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27207
-
Oliver Hader updated the commit message in patch set 6 08/28/18, 19:32
-
TYPO3com voted on patch set 5 V +1 08/28/18, 19:37 Completed build in 12m 39s on Tue, 28 Aug, 09:37 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27208
-
TYPO3com voted on patch set 6 V +1 08/28/18, 19:48 Completed build in 12m 40s on Tue, 28 Aug, 09:48 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27211
-
Benni Mack voted on patch set 6 V +1 CR +1 08/28/18, 19:48
-
Georg Ringer voted on patch set 6 CR +1 08/28/18, 19:49
-
Wouter Wolters voted on patch set 6 CR +1 08/28/18, 20:32
-
Andreas Kienast voted on patch set 6 V +2 CR +2 08/29/18, 06:33
-
Andreas Kienast merged patch set 7 08/29/18, 06:33
-
Oliver Hader commented on patch set 7 08/29/18, 12:19
-1 something essential is missing here... interesting nobody did realize that... -
Oliver Hader commented on patch set 7 08/29/18, 12:43
e.g. I get a "#1535189872: Manager needs to be initialized first" when testing it with the core... -
Benni Mack commented on patch set 7 08/29/18, 13:05
Have you run composer install after applying the patch?