Review main Merged

58042[TASK] Use typo3/phar-stream-wrapper package

Oliver Hader CR +2 V +2 Hard +188 −587 updated 08/29/18, 13:05

Commit message

PharStreamWrapper has been released as standalone package under
the MIT license: https://github.com/TYPO3/phar-stream-wrapper

Stream invocation is handled by the new composer package, previous
classes PharStreamWrapper and PharStreamWrapperException have been
removed from the TYPO3 core but are still kept in class alias maps
for compatibility reasons. Since the standalone package is now
independent from TYPO3 constraints, the TYPO3 specific logic to
intercept Phar invocations has been moved to the new class
PharStreamWrapperInterceptor.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1622

  1. Oliver Hader uploaded patch set 1 08/26/18, 20:43

  2. TYPO3com voted on patch set 1 V -1 08/26/18, 20:43 Completed build in 09s on Sun, 26 Aug, 10:43 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27103

  3. Oliver Hader uploaded patch set 2 08/26/18, 20:44

  4. TYPO3com voted on patch set 2 V -1 08/26/18, 20:54 Completed build in 09m 38s on Sun, 26 Aug, 10:54 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27104

  5. Oliver Hader uploaded patch set 3 08/26/18, 21:06

  6. TYPO3com voted on patch set 3 V +1 08/26/18, 21:16 Completed build in 09m 31s on Sun, 26 Aug, 11:16 PM Test Summary: 35293 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27105

  7. Mathias Brodala commented on patch set 3 08/27/18, 08:14

    Would it make sense to move these to a class alias map instead?
  8. Benni Mack commented on patch set 3 08/28/18, 17:39

    please also adjust the composer.json within typo3/sysext/core
  9. Oliver Hader uploaded patch set 4 08/28/18, 19:20

  10. Oliver Hader updated the commit message in patch set 5 08/28/18, 19:24

  11. TYPO3com voted on patch set 4 V +1 08/28/18, 19:31 Completed build in 11m 00s on Tue, 28 Aug, 09:31 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27207

  12. Oliver Hader updated the commit message in patch set 6 08/28/18, 19:32

  13. TYPO3com voted on patch set 5 V +1 08/28/18, 19:37 Completed build in 12m 39s on Tue, 28 Aug, 09:37 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27208

  14. TYPO3com voted on patch set 6 V +1 08/28/18, 19:48 Completed build in 12m 40s on Tue, 28 Aug, 09:48 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27211

  15. Benni Mack voted on patch set 6 V +1 CR +1 08/28/18, 19:48

  16. Georg Ringer voted on patch set 6 CR +1 08/28/18, 19:49

  17. Wouter Wolters voted on patch set 6 CR +1 08/28/18, 20:32

  18. Andreas Kienast voted on patch set 6 V +2 CR +2 08/29/18, 06:33

  19. Andreas Kienast merged patch set 7 08/29/18, 06:33

  20. Oliver Hader commented on patch set 7 08/29/18, 12:19

    -1 something essential is missing here... interesting nobody did realize that...
  21. Oliver Hader commented on patch set 7 08/29/18, 12:43

    e.g. I get a "#1535189872: Manager needs to be initialized first" when testing it with the core...
  22. Benni Mack commented on patch set 7 08/29/18, 13:05

    Have you run composer install after applying the patch?