Review main Merged

58047[TASK] Clean up unused / dead code

Christian Kuhn CR +2 V +2 Normal +48 −115 updated 08/30/18, 16:34

Commit message

A series of unused and dead code places are fixed with the patch:
* Switch + return + break -> the break is obsolete
* A couple of 'too many arguments' when calling methods
* Various assignments of variables that are never used

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
  • Verified V +2
    • Wouter Wolters +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 47

Show 27 more files

Review log 912

  1. Christian Kuhn uploaded patch set 1 08/27/18, 12:03

  2. TYPO3com voted on patch set 1 V -1 08/27/18, 12:04 Completed build in 17s on Mon, 27 Aug, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27119

  3. Christian Kuhn uploaded patch set 2 08/27/18, 12:10

  4. TYPO3com voted on patch set 2 V +1 08/27/18, 12:19 Completed build in 09m 10s on Mon, 27 Aug, 02:19 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27120

  5. Wouter Wolters commented on patch set 2 V +1 CR +1 08/27/18, 12:51

    DeletedRecordsCommand.php:155

    we execute twice here, combine?

    LostFilesCommand.php:245

    we execute twice now, can we combine this?
  6. Christian Kuhn commented on patch set 2 08/27/18, 13:08

    DeletedRecordsCommand.php:155 Reply

    could be improved with another patch to not change focus of this one.

    LostFilesCommand.php:245 Reply

    could be improved with another patch to not change focus of this one.
  7. Anja Leichsenring updated the commit message in patch set 3 08/27/18, 14:00

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/27/18, 14:03

  9. TYPO3com voted on patch set 3 V +1 08/27/18, 14:12 Completed build in 12m 18s on Mon, 27 Aug, 04:12 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27128

  10. Wouter Wolters voted on patch set 3 V +2 CR +2 08/27/18, 14:36

  11. Wouter Wolters merged patch set 4 08/27/18, 14:36

  12. Susi Moog commented on patch set 4 08/30/18, 16:34