58048[TASK] Prevent superfluous filters in DataMapProcessor
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Susi Moog +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1723
-
Nicole Hummel uploaded patch set 1 08/27/18, 14:06
-
TYPO3com voted on patch set 1 V +1 08/27/18, 14:19 Completed build in 12m 10s on Mon, 27 Aug, 04:19 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27130
-
Nicole Hummel uploaded patch set 2 09/04/18, 10:24
-
TYPO3com voted on patch set 2 V +1 09/04/18, 10:34 Completed build in 09m 13s on Tue, 4 Sep, 12:34 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27755
-
Oliver Hader commented on patch set 2 09/04/18, 11:46
Should be tested carefully...DataMapProcessor.php:1111This comparison is superfluous -
Oliver Hader commented on patch set 2 09/04/18, 11:47
By the way, why is this a bugfix? I did not find any mention of a misbehavior... -
Nicole Hummel uploaded patch set 3 09/04/18, 11:55
-
Nicole Hummel commented on patch set 2 09/04/18, 11:56
@Olly: For me it was a bugfix because it streamlines the internal api to provide different output from one function. I changed it to TASK now.DataMapProcessor.php:1111ReplyDone -
TYPO3com voted on patch set 3 V +1 09/04/18, 12:06 Completed build in 11m 01s on Tue, 4 Sep, 02:06 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27763
-
Benni Mack updated the commit message in patch set 4 12/14/18, 09:55
-
Benni Mack commented on patch set 4 12/14/18, 09:55
Updated the releases line -
TYPO3com voted on patch set 4 V +1 12/14/18, 10:10 Completed build in 14m 50s on Fri, 14 Dec, 11:10 AM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30683
-
Susi Moog updated the commit message in patch set 5 10/25/19, 18:02
-
Susi Moog voted on patch set 5 CR +1 10/25/19, 18:05
-
TYPO3com voted on patch set 5 V +1 10/25/19, 18:14 Completed build in 11m 18s on Fri, 25 Oct, 06:14 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37727
-
Susi Moog updated the commit message in patch set 6 11/09/19, 11:18
-
TYPO3com voted on patch set 6 V +1 11/09/19, 11:28 Completed build in 09m 26s on Sat, 9 Nov, 11:28 AM Test Summary: 48178 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38154
-
Susi Moog voted on patch set 6 CR +1 11/09/19, 12:01
-
Oliver Hader voted on patch set 6 CR +1 11/18/19, 11:45
-
Andreas Kienast voted on patch set 6 CR +1 11/18/19, 16:05
-
Benni Mack voted on patch set 6 V +1 CR +1 11/19/19, 08:45
-
Oliver Hader voted on patch set 6 V +2 CR +2 11/19/19, 10:26
-
Oliver Hader merged patch set 7 11/19/19, 10:26