Review main Abandoned

58050[BUGFIX] Prevent processing unchanged items in DataMapProcessor

Nicole Hummel CR 0 V 0 Easy +15 −11 updated 11/28/21, 22:07

Commit message

If an item has no changed values in comparison to its database
values, it is superfluous to process the item as well as any
parent or sibling records. This patch fetches all current database
values and compares them to the given item state.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3145

Show 1420 earlier messages
  1. Nicole Hummel uploaded patch set 1 08/27/18, 14:41

  2. TYPO3com voted on patch set 1 V -1 08/27/18, 14:51 Completed build in 10m 18s on Mon, 27 Aug, 04:51 PM Test Summary: 6 of 35529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27134

  3. Nicole Hummel uploaded patch set 2 09/04/18, 13:28

  4. TYPO3com voted on patch set 2 V +1 09/04/18, 13:38 Completed build in 09m 46s on Tue, 4 Sep, 03:38 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27774

  5. Nicole Hummel updated the commit message in patch set 3 09/04/18, 14:48

  6. TYPO3com voted on patch set 3 V +1 09/04/18, 14:59 Completed build in 10m 22s on Tue, 4 Sep, 04:59 PM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27778

  7. Nicole Hummel uploaded patch set 4 09/04/18, 21:49

  8. Nicole Hummel updated the commit message in patch set 5 09/04/18, 21:56

  9. TYPO3com voted on patch set 4 V -1 09/04/18, 22:00 Completed build in 10m 40s on Wed, 5 Sep, 12:00 AM Test Summary: 21 of 36328 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27785

  10. TYPO3com voted on patch set 5 V -1 09/04/18, 22:05 Completed build in 08m 54s on Wed, 5 Sep, 12:05 AM Test Summary: 21 of 36328 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27786

  11. Nicole Hummel uploaded patch set 6 09/04/18, 22:24

  12. Nicole Hummel commented on patch set 3 09/04/18, 22:25

    Back to patch set 3 as limiting the fields does have to many site effects.
  13. TYPO3com voted on patch set 6 V +1 09/04/18, 22:36 Completed build in 10m 59s on Wed, 5 Sep, 12:36 AM Test Summary: 35980 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27788

  14. Tymoteusz Motylewski commented on patch set 6 09/07/18, 19:12

    DataMapProcessor.php:820

    The method signature is changed anyway, so lets remove the non ised param
  15. Oliver Hader commented on patch set 6 09/07/18, 20:02

    Again, it looks like an optimization instead of a bugfix. I did not find any details about the test-scenario in the forge ticket. Anyway, I don't have much time currently (the next few weeks) to dig into changes in this area - my focus is different until v9 LTS
  16. Oliver Hader wrote 09/07/18, 20:02

    Removed reviewer Benni Mack.
  17. Oliver Hader wrote 09/07/18, 20:02

    Removed reviewer Oliver Hader.
  18. Nicole Hummel commented on patch set 6 09/09/18, 09:57

    @Olly: We have a huge performance problem on saving data records with a lot of IRRE elements references. The forge ticket does describe what is given, what I do expect and what happens instead. This patch tries to lower database queries and redundancy that are superfluous because no information has changed. If you have the feeling, that this is not a real problem and therefore the fix is not valid to be tackled as bugfix, please feel free to change the commit message. For me, processing superfluous information is considered as a bug and unintended behaviour.
  19. Benni Mack updated the commit message in patch set 7 12/14/18, 09:56

  20. Benni Mack commented on patch set 7 12/14/18, 09:56

    Updated the releases line
  1. TYPO3com voted on patch set 7 V +1 12/14/18, 10:17 Completed build in 15m 57s on Fri, 14 Dec, 11:17 AM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30684

  2. Benni Mack uploaded patch set 8 04/17/19, 20:46

  3. TYPO3com voted on patch set 8 V -1 04/17/19, 20:57 Completed build in 10m 56s on Wed, 17 Apr, 10:57 PM Test Summary: 1 of 47866 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33323

  4. Susi Moog rebased onto patch set 9 12/20/19, 07:58

  5. TYPO3com voted on patch set 9 V +1 12/20/19, 08:09 Completed build in 09m 03s on Fri, 20 Dec, 08:09 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39545

  6. Tobi Kretschmann commented on patch set 9 01/16/20, 15:09

    DataMapProcessor.php:180 Unresolved

    the variable name should also be adjusted

    DataMapProcessor.php:199 Unresolved

    flexform data will always be different, since the DB value is a xml string and the $value is still an array. if that's the case then it will simply behave as before, which I think is ok.

    DataMapProcessor.php:855 Unresolved

    i think the doc block should be adjusted along with the change of method name
  7. Benni Mack uploaded patch set 10 03/19/20, 16:03

  8. Benni Mack voted on patch set 10 V +1 CR +1 03/19/20, 16:07

  9. TYPO3com voted on patch set 10 V +1 03/19/20, 16:14 Completed build in 11m 42s on Thu, 19 Mar, 04:14 PM Test Summary: 72108 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1456

  10. Susi Moog voted on patch set 10 V +1 CR +1 03/23/20, 14:53

  11. Benni Mack commented on patch set 10 V 0 CR 0 03/23/20, 15:26

    Just wondered again: If we fetch _all_ fields, wouldn't this handle non-related fields as well?
  12. Benni Mack wrote 03/23/20, 15:26

    Removed reviewer Christian Kuhn.
  13. Susi Moog wrote 03/23/20, 15:26

    Removed Verified+1 by Susanne Moog <look@susi.dev>
  14. Susi Moog wrote 03/23/20, 15:26

    Removed Code-Review+1 by Susanne Moog <look@susi.dev>
  15. Benni Mack commented on patch set 10 04/30/20, 15:10

    Anyone willing to continue on this? I had some remarks / questions about the patch and no answer for some time now.
  16. Benni Mack updated the commit message in patch set 11 10/21/20, 08:53

  17. TYPO3com voted on patch set 11 V +1 10/21/20, 09:07 Completed build in 13m 43s on Wed, 21 Oct, 09:07 AM Test Summary: 73488 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6713

  18. Tymoteusz Motylewski rebased onto patch set 12 08/29/21, 19:18

  19. core-ci voted on patch set 12 V -1 08/29/21, 19:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15827

  20. Tymoteusz Motylewski commented on patch set 12 08/29/21, 19:40

    CI error looks legit Core: Error handler (BE): PHP Warning: Array to string conversion in /builds/typo3/CI/cms/typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php line 223
  21. Benni Mack rebased onto patch set 13 11/10/21, 11:47

  22. core-ci voted on patch set 13 V -1 11/10/21, 12:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19122

  23. Benni Mack updated the commit message in patch set 14 11/18/21, 10:46

  24. core-ci voted on patch set 14 V -1 11/18/21, 14:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19467

  25. Benni Mack abandoned the change 11/28/21, 22:07

    will abandon this change for the time being - can be picked up later at any time and restored. Just seeing this for 18 months after my first remark...