Review main Abandoned

58051[FEATURE] hook for modifying the dbal schema

Marco Pfeiffer CR 0 V 0 Normal +141 −70 updated 02/27/20, 12:55

Commit message

Adds a new hook that allow to modify the doctrine dbal tables directly.
This makes it easier to dynamically add or modify tables.

Most usages of the old hook are removed and replaced by the new one.
- The DatabaseSchemaService responsible for creating the cf_* tables
  now looks specifically for the a Typo3DatabaseBackend and creates
  tables in the dbal style.
- The CategoryRegistry which adds category fields/relations to any table
  now uses this hook to modify table objects instead of creating a
  CREATE TABLE string just for that one field.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 8

Review log 2028

Show 23 earlier messages
  1. Marco Pfeiffer uploaded patch set 1 08/27/18, 15:11

  2. TYPO3com voted on patch set 1 V -1 08/27/18, 15:11 Completed build in 10s on Mon, 27 Aug, 05:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27136

  3. Marco Pfeiffer uploaded patch set 2 08/27/18, 15:28

  1. TYPO3com voted on patch set 2 V -1 08/27/18, 15:38 Completed build in 09m 47s on Mon, 27 Aug, 05:38 PM Test Summary: 4 of 35532 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27137

  2. Marco Pfeiffer uploaded patch set 3 08/27/18, 16:22

  3. Marco Pfeiffer voted on patch set 3 V +1 CR +1 08/27/18, 16:31

  4. TYPO3com voted on patch set 3 V -1 08/27/18, 16:33 Completed build in 10m 15s on Mon, 27 Aug, 06:33 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27139

  5. Marco Pfeiffer uploaded patch set 4 08/27/18, 16:36

  6. Marco Pfeiffer voted on patch set 4 CR +1 08/27/18, 16:42

  7. Marco Pfeiffer wrote 08/27/18, 16:45

    Removed Code-Review+1 by Marco Pfeiffer <m4pfeiffer@gmail.com>
  8. TYPO3com voted on patch set 4 V +1 08/27/18, 16:45 Completed build in 08m 50s on Mon, 27 Aug, 06:45 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27140

  9. Mathias Brodala commented on patch set 4 CR -1 08/28/18, 07:01

    This needs an feature RST file.
  10. Mathias Brodala commented on patch set 4 08/28/18, 07:02

    Deprecation-85822-DeprecatePageGeneratorrenderContent.rst

    I guess this was supposed to be the feature RST file? ;-)
  11. Marco Pfeiffer uploaded patch set 5 08/28/18, 07:49

  12. TYPO3com voted on patch set 5 V +1 08/28/18, 08:01 Completed build in 11m 31s on Tue, 28 Aug, 10:01 AM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27172

  13. Jan Stockfisch commented on patch set 5 CR -1 08/29/18, 12:07

    CategoryRegistry.php:48

    also here, I'm missing an explanation in the phpdoc (see below)

    CategoryRegistry.php:189

    scince this is deprecated, I'm missing the `trigger_error('Method will be removed in TYPO3 v10', E_USER_DEPRECATED);` line and an explanation in the phpdoc - at least something like "@deprecated since TYPO3 v9, will be removed in TYPO3 v10".

    CategoryRegistry.php:203

    see above

    CategoryRegistry.php:443

    see above
  14. Marco Pfeiffer uploaded patch set 6 08/29/18, 13:11

  15. TYPO3com voted on patch set 6 V -1 08/29/18, 13:23 Completed build in 11m 07s on Wed, 29 Aug, 03:23 PM Test Summary: 6 of 35529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27235

  16. Christian Kuhn commented on patch set 6 09/01/18, 17:37

    Hey Marco. Thx for this patch. It looks good at first glance, I'd only change some details. I think this patch is more a task than a feature and I think we should use the chance to finish that patch after 9.4 release and bring it in. Shouldn't harm, imho, but I'll check with benni for details since I'd love to see the old signal being deprecated in v9 so we can drop it in v10.
  17. Anja Leichsenring commented on patch set 6 12/22/18, 18:10

    ping. This could be picked up again now. Little longer than 9.4, but hey :)
  18. Alexander Schnitzler uploaded patch set 7 12/22/18, 18:20

  19. Alexander Schnitzler commented on patch set 7 12/22/18, 18:21

    Just rebased.
  20. TYPO3com voted on patch set 7 V -1 12/22/18, 18:31 Completed build in 10m 43s on Sat, 22 Dec, 07:31 PM Test Summary: 8 of 48224 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-31113

  21. TYPO3com commented on patch set 7 04/09/19, 13:59 Completed build in 13m 04s on Tue, 9 Apr, 03:59 PM Test Summary: 2236 of 47660 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33144

  22. Anja Leichsenring wrote 09/09/19, 08:44

    Removed reviewer Anja Leichsenring.
  23. Susi Moog commented on patch set 7 10/26/19, 07:55

    We should probably now implement this via PSR-14 Event Dispatching.
  24. Benni Mack commented on patch set 7 02/15/20, 09:54

    @Susi: can you pick this one up? Events are in place.
  25. Benni Mack abandoned the change 02/27/20, 12:55

    no changes happened here for a long time, I will abandon this review now. Issue can stay open and we can work with Events in a new patchset then.