58060[TASK] Always show copy / cut buttons in filelist
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1115
-
Gianluigi Martino uploaded patch set 1 08/28/18, 11:26
-
TYPO3com voted on patch set 1 V +1 08/28/18, 11:35 Completed build in 09m 10s on Tue, 28 Aug, 01:35 PM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27186
-
Riccardo De Contardi commented on patch set 1 09/02/18, 09:41
Currently I am not able to see differences, even after clearing the cache -
Jigal van Hemert commented on patch set 1 V -1 09/02/18, 10:31
After copy/cut there is no paste button visible. That only appears after activating the clipboard. I'll add Benji as reviewer to check if it fits the concepts of UX/UI in the filelist module. This change feels more like a (small) feature. As it's not a bugfix but an enhancement I don't think it should be backported to v8. -
Benni Mack updated the commit message in patch set 2 12/14/18, 09:55
-
Benni Mack commented on patch set 2 12/14/18, 09:55
Updated the releases line -
TYPO3com voted on patch set 2 V +1 12/14/18, 10:09 Completed build in 14m 30s on Fri, 14 Dec, 11:09 AM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30682
-
Susi Moog commented on patch set 2 10/25/19, 17:59
Would you mind updating the patch / resolving the merge conflicts? -
Gianluigi Martino uploaded patch set 3 10/28/19, 07:38
-
TYPO3com voted on patch set 3 V -1 10/28/19, 07:38 Completed build in 13s on Mon, 28 Oct, 07:38 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37814
-
Gianluigi Martino uploaded patch set 4 10/29/19, 12:41
-
TYPO3com voted on patch set 4 V +1 10/29/19, 12:51 Completed build in 09m 41s on Tue, 29 Oct, 12:51 PM Test Summary: 48071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37844
-
Xavier Perseguers commented on patch set 4 CR -1 11/02/19, 15:51
I wonder why we want to make the behaviour of TYPO3 less consistent... current behaviour makes sense since it's the same as in the Web > List module. For me the real need is to make File > List even more consistent and similar with Web > List which is more powerful rather than making them diverge and make those two central module more isolated from each other. -
Susi Moog commented on patch set 4 02/28/20, 07:21
Xavier is right, it makes more sense to keep the interfaces consistent - in v10 we additionally show the copy/cut/clipboard options also when searching for files (so it's usable everywhere). For consistencies sake, I'm going to abandon this review and close the issue. If we need changes in this area we should tackle both list and file module at the same time. -
Susi Moog abandoned the change 02/28/20, 07:21
see previous comment