58067[TASK] Deprecate FrontendEditingController
Commit message
Review
-
Code review CR +2
- Andreas Wolf +2
- Daniel Goerz +1
- Georg Ringer +1
- Anja Leichsenring +1
- Jörg Bösche +1
-
Verified V +2
- Georg Ringer +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php2+1 −13
- typo3/sysext/backend/ext_localconf.php+0 −2
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+7 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-86110-FrontendEditingController.rstnew+36 −0
- typo3/sysext/feedit/Classes/Middleware/FrontendEditInitiator.php+9 −8
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php+5 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyProtectedMatcher.php+20 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php1+0 −15
Review log 2434
Show 79 earlier messages
-
Benni Mack uploaded patch set 1 08/29/18, 08:04
-
TYPO3com voted on patch set 1 V +1 08/29/18, 08:14 Completed build in 09m 53s on Wed, 29 Aug, 10:14 AM Test Summary: 35295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27227
-
Daniel Goerz voted on patch set 1 V +1 CR +1 08/30/18, 07:26
-
Daniel Goerz commented on patch set 1 CR -1 08/30/18, 08:31
We need a ticket and RST :) -
Benni Mack commented on patch set 1 CR -2 08/30/18, 09:40
yeah, we need to work on admin panel first. -
Anja Leichsenring uploaded patch set 2 09/03/18, 14:47
-
Benni Mack voted on patch set 2 CR +1 09/03/18, 14:55
-
TYPO3com voted on patch set 2 V +1 09/03/18, 15:00 Completed build in 12m 42s on Mon, 3 Sep, 05:00 PM Test Summary: 36010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27650
-
Anja Leichsenring uploaded patch set 3 09/03/18, 15:06
-
TYPO3com voted on patch set 3 V +1 09/03/18, 15:16 Completed build in 09m 36s on Mon, 3 Sep, 05:16 PM Test Summary: 36010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27652
-
Anja Leichsenring uploaded patch set 4 09/03/18, 15:53
-
Christian Kuhn commented on patch set 3 09/03/18, 15:55
FrontendBackendUserAuthentication.php:47these 4 properties are all still public. this does not trigger the trait magic methods! thus, all 4 need to be set to protected to properly trigger the deprecation log.PropertyPublicMatcher.php:4this should go to PropertyProtectedMatcher (please check the other three from the class, too). -
Oliver Hader voted on patch set 4 CR +1 09/03/18, 15:57
-
Anja Leichsenring uploaded patch set 5 09/03/18, 15:58
-
Christian Kuhn commented on patch set 3 09/03/18, 15:59
FrontendBackendUserAuthentication.php:47Replyah, ok. the properties are still used in core for b/w compat reasons. this is why they are still public and thus can't log deprecation entries. in this case i think we should remove the trait usage, and state in the .rst file included in this patch and in the .rst file of the 3 other properties that no deprecation notes are logged for these usages. -
Anja Leichsenring uploaded patch set 6 09/03/18, 16:03
-
Anja Leichsenring uploaded patch set 7 09/03/18, 16:03
-
Anja Leichsenring uploaded patch set 8 09/03/18, 16:06
-
TYPO3com voted on patch set 4 V -1 09/03/18, 16:11 Completed build in 13m 00s on Mon, 3 Sep, 06:11 PM Test Summary: 24 of 36304 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27661
-
Anja Leichsenring uploaded patch set 9 09/03/18, 16:13
-
TYPO3com voted on patch set 8 V -1 09/03/18, 16:18 Completed build in 32s on Mon, 3 Sep, 06:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27667
-
TYPO3com voted on patch set 5 V +1 09/03/18, 16:20 Completed build in 14m 31s on Mon, 3 Sep, 06:20 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27663
-
TYPO3com voted on patch set 6 V +1 09/03/18, 16:22 Completed build in 16m 57s on Mon, 3 Sep, 06:22 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27664
-
TYPO3com voted on patch set 7 V +1 09/03/18, 16:27 Completed build in 21m 31s on Mon, 3 Sep, 06:27 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27665
-
TYPO3com voted on patch set 9 V +1 09/03/18, 16:35 Completed build in 16m 54s on Mon, 3 Sep, 06:35 PM Test Summary: 35956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27668
-
Georg Ringer uploaded patch set 10 09/03/18, 20:41
-
Georg Ringer voted on patch set 10 V +1 CR +1 09/03/18, 20:42
-
TYPO3com voted on patch set 10 V +1 09/03/18, 20:53 Completed build in 11m 50s on Mon, 3 Sep, 10:53 PM Test Summary: 35977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27721
-
Jörg Bösche voted on patch set 10 CR +1 09/04/18, 06:20
-
Andreas Wolf voted on patch set 10 CR +2 09/04/18, 06:35
-
Daniel Goerz voted on patch set 10 CR +1 09/04/18, 06:41
-
Anja Leichsenring voted on patch set 10 V +1 CR +1 09/04/18, 18:43
-
Georg Ringer voted on patch set 10 V +2 09/05/18, 08:03
-
Georg Ringer merged patch set 11 09/05/18, 08:03