Review main Merged

58069[BUGFIX] Missing initialization of typo3/phar-stream-wrapper

Oliver Hader CR +2 V +2 Easy +21 −26 updated 08/31/18, 14:11

Commit message

Functional tests now rely on \TYPO3\CMS\Core\Core\Bootstrap
is setting up the PharStreamWrapper and check that behavior.

Review

  • Code review CR +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Andreas Kienast +1
  • Verified V +2
    • Frans Saris +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 2131

Show 36 earlier messages
  1. Oliver Hader uploaded patch set 1 08/29/18, 12:56

  2. TYPO3com voted on patch set 1 V -1 08/29/18, 13:02 Completed build in 05m 57s on Wed, 29 Aug, 03:02 PM Test Summary: 5655 of 35529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27234

  3. Oliver Hader uploaded patch set 2 08/29/18, 13:14

  4. TYPO3com voted on patch set 2 V -1 08/29/18, 13:24 Completed build in 10m 16s on Wed, 29 Aug, 03:24 PM Test Summary: 111 of 35529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27236

  5. Oliver Hader uploaded patch set 3 08/29/18, 14:55

  6. TYPO3com voted on patch set 3 V +1 08/29/18, 15:04 Completed build in 09m 01s on Wed, 29 Aug, 05:04 PM Test Summary: 35307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27244

  1. Tymoteusz Motylewski commented on patch set 3 08/29/18, 15:15

    Bootstrap.php:706

    do I get it correctly, that on every request TYPO3 is throwing this exception and catching it? Can we make throwing an exception and exception? ;)
  2. Oliver Hader voted on patch set 3 CR -1 08/29/18, 15:26

  3. Oliver Hader commented on patch set 3 08/29/18, 15:27

    Bootstrap.php:706 Reply

    Yeah, you're right... the destroy call here is basically for functional tests and the missing process isolation...
  4. Oliver Hader uploaded patch set 4 08/30/18, 08:17

  5. TYPO3com voted on patch set 4 V -1 08/30/18, 08:17 Completed build in 09s on Thu, 30 Aug, 10:17 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27282

  6. Oliver Hader uploaded patch set 5 08/30/18, 08:19

  7. TYPO3com voted on patch set 5 V -1 08/30/18, 08:20 Completed build in 18s on Thu, 30 Aug, 10:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27284

  8. Oliver Hader uploaded patch set 6 08/30/18, 08:20

  9. TYPO3com voted on patch set 6 V +1 08/30/18, 08:31 Completed build in 10m 22s on Thu, 30 Aug, 10:31 AM Test Summary: 35319 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27285

  10. Oliver Hader uploaded patch set 7 08/30/18, 17:15

  11. TYPO3com voted on patch set 7 V +1 08/30/18, 17:31 Completed build in 10m 34s on Thu, 30 Aug, 07:31 PM Test Summary: 35376 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27338

  12. Oliver Hader uploaded patch set 8 08/30/18, 22:35

  13. TYPO3com voted on patch set 8 V +1 08/30/18, 22:45 Completed build in 09m 16s on Fri, 31 Aug, 12:45 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27375

  14. Oliver Hader uploaded patch set 9 08/31/18, 07:37

  15. Oliver Hader commented on patch set 9 CR -1 08/31/18, 07:38

    Wrong
  16. Oliver Hader uploaded patch set 10 08/31/18, 07:41

  17. TYPO3com voted on patch set 9 V -1 08/31/18, 07:51 Completed build in 13m 43s on Fri, 31 Aug, 09:51 AM Test Summary: 90 of 36249 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27381

  18. TYPO3com voted on patch set 10 V +1 08/31/18, 08:01 Completed build in 19m 00s on Fri, 31 Aug, 10:01 AM Test Summary: 35364 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-27384

  19. Christian Kuhn voted on patch set 10 V +1 CR +1 08/31/18, 10:43

  20. Wouter Wolters voted on patch set 10 CR +1 08/31/18, 11:35

  21. Frans Saris commented on patch set 10 CR +1 08/31/18, 12:16

    How to verify this?
  22. Andreas Kienast voted on patch set 10 CR +1 08/31/18, 12:17

  23. Oliver Hader commented on patch set 10 08/31/18, 12:21

    Testing e.g. * `file_exists('phar:///path/to/fileadmin/bundle.phar');` * `file_exists('phar:///phat/to/typo3conf/ext/extension/bundle.phar');`
  24. Frans Saris voted on patch set 10 V +2 CR +2 08/31/18, 14:11

  25. Frans Saris merged patch set 11 08/31/18, 14:11